Update documentation to angular 18 #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@angular/core, because of "Incompatible peer dependencies found" error when updating to @angular/core@18 @angular/cli@18
Also refactor the data service and menu service to make the app run again, and remove a lot of redundant old code.
* dev: Release/fhi-angular-components/4.4.2 (#683) Bugfix/fhi-tree-view-selection (#679) Add test for undefined in FhiTreeViewNavigationComponent (#680) Release/fhi-angular-highcharts/4.4.0 (#681) Bugfix/highcharts dynamically add diagram types to nav (#665) enhancement/highcharts Add support for showing a description below the title in (#673) Adjust allowed max widths on the Highcharts (#672) Update documentation for Interface FhiDiagramUnit (#670) Reduce max decimal places to 9 (#669) Don't remove decimals if they end with zero (#668) Add null check for unit.decimals (#667) Add support for showing diagram type line with multiple series even if flagged. (#664)
* dev: Release/fhi-angular-highcharts/5.0.1 (#695)
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-698.westeurope.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-698.westeurope.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-698.westeurope.2.azurestaticapps.net |
robinzaal
reviewed
Sep 20, 2024
src/app/core/mock-db.ts
Outdated
| AllData, // TODO: deprecate when all items use new system | ||
| }; | ||
| } | ||
| if (urlSegment === 'LibraryItemsSharedData') return LibraryItemsSharedData; |
There was a problem hiding this comment.
Nitpick:
How about something like this? It should be more performant and might be more readable.
const dataMapping = {
'LibraryItemsSharedData': LibraryItemsSharedData,
'LibraryItemGroupsSharedData': LibraryItemGroupsSharedData,
'AccordionsData': AccordionsData,
'AlertsData': AlertsData,
'BadgesData': BadgesData,
'BreadcrumbsData': BreadcrumbsData,
'ButtonsData': ButtonsData,
'CardsData': CardsData,
'ColorsData': ColorsData,
'DrawersData': DrawersData,
'ErrorPagesData': ErrorPagesData,
'FormControlsData': FormControlsData,
'GlobalFootersData': GlobalFootersData,
'GlobalHeadersData': GlobalHeadersData,
'HighchartsData': HighchartsData,
'IconsData': IconsData,
'LayoutTemplatesData': LayoutTemplatesData,
'ModalsData': ModalsData,
'NavsData': NavsData,
'PaginationsData': PaginationsData,
'ProgressIndicatorsData': ProgressIndicatorsData,
'PrototypeFormsData': PrototypeFormsData,
'PrototypeTablesData': PrototypeTablesData,
'SearchData': SearchData,
'TablesData': TablesData,
'TagsData': TagsData,
'TimeSelectorsData': TimeSelectorsData,
'ToastsData': ToastsData,
'TooltipPopoverData': TooltipPopoverData,
'TreeViewsData': TreeViewsData,
'TypographyData': TypographyData
};
return dataMapping[urlSegment] || null;
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-698.westeurope.2.azurestaticapps.net |
robinzaal
approved these changes
Sep 20, 2024
proand
pushed a commit
that referenced
this pull request
Sep 24, 2024
* dev: Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688) Release/fhi-angular-components/4.4.2 (#683) Bugfix/fhi-tree-view-selection (#679) Add test for undefined in FhiTreeViewNavigationComponent (#680)
proand
pushed a commit
that referenced
this pull request
Oct 9, 2024
* dev: (52 commits) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699) Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688) Release/fhi-angular-components/4.4.2 (#683) Bugfix/fhi-tree-view-selection (#679) Add test for undefined in FhiTreeViewNavigationComponent (#680) Release/fhi-angular-highcharts/4.4.0 (#681) ...
proand
pushed a commit
that referenced
this pull request
Oct 15, 2024
* dev: (21 commits) Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699) Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688) Release/fhi-angular-components/4.4.2 (#683) Bugfix/fhi-tree-view-selection (#679) ...
proand
pushed a commit
that referenced
this pull request
Oct 16, 2024
* dev: (22 commits) Changes from @folkehelseinstituttet/angular-highcharts/v/4.5.0 (#726) Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699) Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688) Release/fhi-angular-components/4.4.2 (#683) ...
proand
pushed a commit
that referenced
this pull request
Oct 17, 2024
* dev: Changes from @folkehelseinstituttet/angular-highcharts/v/4.6.0 (#729) Changes from @folkehelseinstituttet/angular-highcharts/v/4.5.0 (#726) Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699) Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #654