Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than one instance on the same page
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-717.westeurope.2.azurestaticapps.net |
VillereV
approved these changes
Oct 10, 2024
proand
pushed a commit
that referenced
this pull request
Oct 11, 2024
* dev: Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699)
proand
pushed a commit
that referenced
this pull request
Oct 15, 2024
* dev: (21 commits) Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699) Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688) Release/fhi-angular-components/4.4.2 (#683) Bugfix/fhi-tree-view-selection (#679) ...
proand
pushed a commit
that referenced
this pull request
Oct 16, 2024
* dev: (22 commits) Changes from @folkehelseinstituttet/angular-highcharts/v/4.5.0 (#726) Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699) Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688) Release/fhi-angular-components/4.4.2 (#683) ...
proand
pushed a commit
that referenced
this pull request
Oct 17, 2024
* dev: Changes from @folkehelseinstituttet/angular-highcharts/v/4.6.0 (#729) Changes from @folkehelseinstituttet/angular-highcharts/v/4.5.0 (#726) Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) Enhancement/higcharts Add description also in full screen view (#710) Internal/update contributing (#707) Internal/table of components (#712) Bugfix/remove deprecated prop (#706) Internal/Add and info box on the "Komponenter"-landing page, (#708) Internal/update top menu (#705) Internal/update footer (#699) Update documentation app to angular 18 (#698) Release/fhi-angular-components/5.0.1 (#696) Release/fhi-angular-highcharts/5.0.2 (#697) Release/fhi-angular-highcharts/5.0.1 (#695) Release/fhi-angular-highcharts/5.0.0 (#693) Release/fhi-angular-components/5.0.0 (#692) Update to Angular 18 in @folkehelseinstituttet/angular-highcharts (#691) Update to Angular 18 in @folkehelseinstituttet/angular-components (#689) Bugfix/highcharts: Don't set default diagram types (#688)
proand
pushed a commit
that referenced
this pull request
Oct 17, 2024
* dev: Update Fhi.Frontend.Style to lates version (#734) Release/fhi-angular-components/5.1.0 (#733) Release/fhi-angular-highcharts/5.1.0 (#732) Changes from @folkehelseinstituttet/angular-components/4.5.0 (#731) Changes from @folkehelseinstituttet/angular-highcharts/v/4.6.0 (#729) Changes from @folkehelseinstituttet/angular-highcharts/v/4.5.0 (#726) Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717)
proand
added a commit
that referenced
this pull request
Jan 27, 2025
* Bugfix/tree-view-selection Make sure there is no duplicate IDs on checkboxes (or radios) if more than one instance on the same page (#717) * Changes from patch @folkehelseinstituttet/angular-highcharts/v/4.4.1 (#704) * Fix so table don't break if flagged data (#702) Also rename and improve implementation of the number test in the template. * Changes from @folkehelseinstituttet/angular-highcharts/v/4.5.0 (#726) * Changes from @folkehelseinstituttet/angular-highcharts/v/4.6.0 (#729) * Changes from @folkehelseinstituttet/angular-components/4.5.0 (#731) * Release/fhi-angular-highcharts/5.1.0 (#732) * Release/fhi-angular-components/5.1.0 (#733) * Update Fhi.Frontend.Style to lates version (#734) * Fix selected value not visible before ng-select is touched * Make tree view navigation standalone (#747) Co-authored-by: Bjørn-Vegard Thoresen <[email protected]> * Enhancement/Make FhiAutosuggestComponent standalone (#751) * Bugfix/highcharts decimals (#744) * Fix not zero decimals in tooltip when unit.decimals set to 0 * Fix inconsisten max 9 decimals * Make FhiMultiselectComponent standalone (#755) * Release/fhi-angular-components/5.2.0 (#757) * Update CHANGELOG * Enhancement/highcharts disable diagramtypes cleanup (#761) Remove two redundant disable tests, add two new, and refactor all disable tests. Remove: - `noSeriesOrNoData` - `allDataInOneOrMoreSeriesAreFlagged` Add: - `notAllUnitsFoundInSeries` - `onlyOneSerieAndAllDataAreFlagged` Refactoring: - Add enum msgId - Remove diagram type switch, use if tests instead - Test for one or more diagram type pr. test - Call one or more test inside the if tests - Rename, and rewrite all the disable tests * Release/fhi-angular-highcharts/5.2.0 (#764) * Enhancement/highcharts category axis title (#763) * Add xAxis options * Add interface FhiDiagramCategoryAxis * Update qualitative series in _all.scss (#771) * Update qualitative series in _all.scss * Update CHANGELOG.md * Update CHANGELOG.md * FhiAngularHighcharts: Use cloneDeep() to make diagramOptions immutable (#765) * Enhancement/tree view selection search (#769) * Make the search work on key down, and start at first character * Make label for filter optional and update README accordingly * Update height and max-height on list while searching to reduce "jumping" * Enhancement/highcharts to many zeros in tooltip (#773) * Rewrite decimals instead of formatting decimals in table template and tooltip Remove tooltip.valueDecimals in options service Remove code for setting decimals in table-servie Remove number pipe in table template * Update highcharts doc (#775) * Remove logs * Update README * Enhancement/ignore unknown diagram types (#776) * Add test for illegal diagram type, and for multiple equal diagram types * Enhancement/highcharts line design (#779) * Update css for highcharts-line-series * Enhancement/highcharts always show flags (#780) * Remove test for flagged series in canShowFooter() * Add test for units in canShowFooter() * Enhancement/highcharts diagram menu styling (#781) * Internal/update landing page (#787) * Enhancement/mark required inputs (#784) * Bugfix/tree view selection immutable ids (#778) * Add new internal model with a property `internal.id` in order to make FhiTreeViewSelectionItem.id immutable * Release/fhi-angular-components/5.3.0 (#795) * Release/fhi-angular-highcharts/5.3.0 (#796) --------- Co-authored-by: Bernt Andersen <[email protected]> Co-authored-by: Bjørn-Vegard Thoresen <[email protected]> Co-authored-by: Bjørn-Vegard Thoresen <[email protected]> Co-authored-by: Trygve Bernhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (or radios) if more than one instance of
FhiTreeViewCheckboxComponentorFhiTreeViewRadioComponenton the same page.This closes #716
See #628 for full description of the bug.