Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Angular v18 #654

Closed
proand opened this issue Sep 5, 2024 · 2 comments · Fixed by #689, #691, #693, #692 or #698
Closed

Update to Angular v18 #654

proand opened this issue Sep 5, 2024 · 2 comments · Fixed by #689, #691, #693, #692 or #698
Assignees
@robinzaal
Labels
Enhancement Improvements or additions to features Status: Confirmed Confirmed as valid by a maintainer

Comments

@proand
Copy link
Member

proand commented Sep 5, 2024 •
edited
Loading

Description

Update the following packages and app to Angular to major version 18:

Acceptance Criteria

Check that Angular is v18, and that all other dependencies are okay, in these three files:

  • ../Fhi.Frontend.Demo/projects/fhi-angular-components/package.json
  • ../Fhi.Frontend.Demo/projects/fhi-angular-highcharts/package.json
  • ../Fhi.Frontend.Demo/package.json
@proand proand added Status: Unconfirmed Not yet confirmed as valid by a maintainer (added by default) Enhancement Improvements or additions to features labels Sep 5, 2024
@proand
Copy link
Member Author

proand commented Sep 5, 2024 •
edited
Loading

Management has granted us some help with this one; @robinzaal will help us 🙂
I will coordinate the job, and we try to get it done in week 37.

@proand proand added Status: Confirmed Confirmed as valid by a maintainer and removed Status: Unconfirmed Not yet confirmed as valid by a maintainer (added by default) labels Sep 5, 2024
This was linked to pull requests Sep 19, 2024
Update to Angular 18 in @folkehelseinstituttet/angular-components #689
Merged
Bugfix/highcharts: Don't set default diagram types #688
Merged
@proand proand removed a link to a pull request Sep 19, 2024
Bugfix/highcharts: Don't set default diagram types #688
Merged
@proand proand linked a pull request Sep 19, 2024 that will close this issue
Update to Angular 18 in @folkehelseinstituttet/angular-highcharts #691
Merged
@proand proand reopened this Sep 19, 2024
@proand
Copy link
Member Author

proand commented Sep 19, 2024

Reopened this since the demo app isn't updated yet.

This was linked to pull requests Sep 19, 2024
Release/fhi-angular-highcharts/5.0.0 #693
Merged
Release/fhi-angular-components/5.0.0 #692
Merged
@proand proand mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinzaal robinzaal

Labels
Enhancement Improvements or additions to features Status: Confirmed Confirmed as valid by a maintainer
Projects
None yet
Milestone
No milestone
2 participants
@robinzaal @proand