Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add French language support #267

Merged
merged 7 commits into from
Feb 12, 2025
Merged

feat: add French language support #267

merged 7 commits into from
Feb 12, 2025

Conversation

aginies
Copy link
Contributor

@aginies aginies commented Feb 11, 2025

Would be nice to have it also in French.

@fmaclen
Copy link
Owner

fmaclen commented Feb 11, 2025

@aginies thanks for submitting the PR, this works so far but you are missing a few more changes:

For reference, here's another PR for a recent language addition:
#241

@aginies
Copy link
Contributor Author

aginies commented Feb 11, 2025

@aginies thanks for submitting the PR, this works so far but you are missing a few more changes:
....
For reference, here's another PR for a recent language addition: #241

Thanks for the reference.
I fixed the missing part. Should be OK now .
regards.

@fmaclen fmaclen changed the title Add FR translation feat: add French language support Feb 12, 2025
@fmaclen
Copy link
Owner

fmaclen commented Feb 12, 2025

Thank you for making those extra changes 👍

@fmaclen fmaclen merged commit c9ef7b3 into fmaclen:main Feb 12, 2025
2 checks passed
@fmaclen
Copy link
Owner

fmaclen commented Feb 12, 2025

🎉 This PR is included in version 0.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants