feat: add German language support #241
Conversation
fmaclen
changed the title
There was a problem hiding this comment.
Thanks again for putting this together.
Now that #234 has been merged there were significant changes to the locales, a handful of keys were removed and several more were added.
Here's the specific list of changes:
https://github.com/fmaclen/hollama/pull/234/files#diff-dfa2062fc0f5cfa7c4ef6179d7480621e7f0ab7a8a0e51fe25df994871186146
tests/settings.test.ts
Outdated
| test.describe('German', () => { | ||
| test.use({ locale: 'de-DE' }); | ||
| test('default language is german', async ({ page }) => { | ||
| await page.goto('/settings'); | ||
| expect(await page.evaluate(() => navigator.language)).toBe('de-DE'); | ||
|
|
||
| await page.evaluate(() => window.localStorage.clear()); | ||
| await page.reload(); | ||
| await expect(page.getByText('Current version')).not.toBeVisible(); | ||
| await expect(page.getByText('Aktuelle Version')).toBeVisible(); | ||
| expect(await page.evaluate(() => window.localStorage.getItem('hollama-settings'))).toContain( | ||
| '"userLanguage":"de"' | ||
| ); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Localization tests have been moved to locales.test.ts.
There was a problem hiding this comment.
Moved now - still need to adapt the messages though.
src/routes/settings/Interface.svelte
Outdated
| { value: 'en', label: 'English' }, | ||
| { value: 'zh-cn', label: '中文 (简体)' }, | ||
| { value: 'es', label: 'Español' }, | ||
| { value: 'pt-br', label: 'Português (Brasil)' }, | ||
| { value: 'de', label: 'Deutsch' }, |
There was a problem hiding this comment.
Let's move Deutsch under English since Germany has the 2nd largest amount of users.
By number of worldwide speakers
jhoermann
force-pushed
the
de-translation
branch
from
eba4639 to
b887435
Compare
jhoermann
force-pushed
the
de-translation
branch
from
3b99156 to
1376902
Compare
|
Did all the changes - can you please check again @fmaclen? |
|
🎉 This PR is included in version 0.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #240