Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Adds support for BuildingsEnabled property #2264

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

scottmcarthur
Copy link
Contributor

Description

  • Adds missing property buildingsEnabled to the Google Maps Flutter plugin.

iOS SDK Reference

(BOOL) buildingsEnabled [read, write, assign]
If set, 3D buildings will be shown where available.

Defaults to YES.
This may be useful when adding a custom tile layer to the map, in order to make it clearer at high > zoom levels. Changing this value will cause all tiles to be briefly invalidated.

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@scottmcarthur
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@scottmcarthur
Copy link
Contributor Author

@iskakaushik The checks are failing because the version number in the pubspec.yaml in my PR is 0.5.21+11 but the commit from #2242 forgot to update their entry to 0.5.21+10 so the CI is expecting +10.

@jmagman
Copy link
Member

jmagman commented Nov 12, 2019

@iskakaushik The checks are failing because the version number in the pubspec.yaml in my PR is 0.5.21+11 but the commit from #2242 forgot to update their entry to 0.5.21+10 so the CI is expecting +10.

Fixing with a bump to +10 with #2267.
Once it merges, you can rebase on that commit.

@ened
Copy link
Contributor

ened commented Dec 3, 2019

hi @scottmcarthur thank you for the PR! Could you please rebase? I think some test_driver files have been renamed. Thank you once again

@scottmcarthur
Copy link
Contributor Author

@ened I have rebased.

@ened
Copy link
Contributor

ened commented Dec 4, 2019

hi @scottmcarthur, almost there! Could you please double check that the new method is called during the e2e test? You have added the e2e method for isBuildingsEnabled, but it needs to be called within a new test within the google_maps.dart file.

@scottmcarthur
Copy link
Contributor Author

scottmcarthur commented Dec 4, 2019

@ened I updated packages/google_maps_flutter/example/test_driver/google_maps_e2e.dart which did not have the test. I couldn't find a google_maps.dart file. Is this the right one?

@ened
Copy link
Contributor

ened commented Dec 4, 2019

@scottmcarthur yes, is correct. Thank you for updating the test!

Copy link
Contributor

@ened ened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & can land once the checks pass.

@scottmcarthur
Copy link
Contributor Author

@ened Great. Thanks for your help.

@ened
Copy link
Contributor

ened commented Dec 4, 2019

@scottmcarthur - please take a look at the failed tests. :)

@scottmcarthur
Copy link
Contributor Author

@ened I am not sure why the 'testScreenCoordinate' would fail. The functionality I have added is a simple value not related to screen location. It should work in the same way as toggling traffic on/off. I am not sure how to resolve this.

@ened ened merged commit 9175e0f into flutter:master Dec 6, 2019
@scottmcarthur scottmcarthur deleted the google_maps_buildings branch December 9, 2019 17:01
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants