-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] Adds support for BuildingsEnabled property #2264
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@iskakaushik The checks are failing because the version number in the |
Fixing with a bump to +10 with #2267. |
1d76cb0
to
5e4e8e9
Compare
hi @scottmcarthur thank you for the PR! Could you please rebase? I think some test_driver files have been renamed. Thank you once again |
5e4e8e9
to
ff05f28
Compare
@ened I have rebased. |
hi @scottmcarthur, almost there! Could you please double check that the new method is called during the e2e test? You have added the e2e method for |
ff05f28
to
cb67abb
Compare
@ened I updated |
@scottmcarthur yes, is correct. Thank you for updating the test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & can land once the checks pass.
@ened Great. Thanks for your help. |
@scottmcarthur - please take a look at the failed tests. :) |
@ened I am not sure why the 'testScreenCoordinate' would fail. The functionality I have added is a simple value not related to screen location. It should work in the same way as toggling traffic on/off. I am not sure how to resolve this. |
Description
buildingsEnabled
to the Google Maps Flutter plugin.iOS SDK Reference
Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?