Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Cast error.code to unsigned long to avoid using NSInteger as %ld format warnings. #2242

Merged
merged 3 commits into from
Oct 29, 2019

Conversation

tommyzed
Copy link
Contributor

Description

Cast error.code to unsigned long to avoid using NSInteger as %ld format warnings.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This to avoid: 

error: values of type 'NSUInteger' should not be used as format arguments; add an explicit cast to 'unsigned long' instead [-Werror,-Wformat]
@tommyzed tommyzed requested a review from iskakaushik as a code owner October 28, 2019 16:24
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh amirh added the submit queue The Flutter team is in the process of landing this PR. label Oct 29, 2019
@mehmetf mehmetf merged commit 421b241 into flutter:master Oct 29, 2019
@tommyzed tommyzed deleted the patch-1 branch October 29, 2019 16:17
@scottmcarthur
Copy link
Contributor

@tommyzed @amirh @mehmetf
The pubspec.yaml for this change was not updated to 0.5.21+10 but the CHANGELOG was.

This is breaking #2264 (and future minor builds of google_maps_flutter) because the CI is expecting the next minor build to be +10 ... but I need to submit my change as +11, to prevent conflict with your change log entry.

Please resolve this, by updating pubspec.yaml to 0.5.21+10

mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants