-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] Cast error.code to unsigned long to avoid using NSInteger as %ld format warnings. #2242
Conversation
This to avoid: error: values of type 'NSUInteger' should not be used as format arguments; add an explicit cast to 'unsigned long' instead [-Werror,-Wformat]
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tommyzed @amirh @mehmetf This is breaking #2264 (and future minor builds of google_maps_flutter) because the CI is expecting the next minor build to be Please resolve this, by updating |
… NSInteger as %ld format warnings. (flutter#2242)
… NSInteger as %ld format warnings. (flutter#2242)
Description
Cast error.code to unsigned long to avoid using NSInteger as %ld format warnings.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?