flutter/plugins pubspec presubmit needs tweaking

[mklim]

Relatively recently we added a presubmit that attempts to verify that each PR increments the major, minor, or patch version in the pubspec.yaml.

It appears to be letting through false negatives in cases where the pubspec.yaml is never changed, but the CHANGELOG is updated: flutter/plugins#2242

This then cascades into later false positives, where future PRs are blocked for having incremented the pubspec.yaml version "too much": flutter/plugins#2264

Edit: @cyanglaz mentioned that the check deliberately ignores CHANGELOG, so that's what should probably be fixed here.

[godofredoc]

Do you know if this is a test problem or a race condition in infra?

[mklim]

I haven't looked deeply into this but I think it's just an issue with the test itself. I'm pretty sure it's not catching all the changes that it should be linting for. I think it may only be checking to see if the pubspec.yaml file was changed and then failing then if the version upgrade wasn't right, when we should at least be checking for CHANGELOG too (and maybe any changed files at all).

Our entire infra has a race condition that can sort of effect his, where presubmits are run on the branch as they are and not the branch's changes applied to tip of tree master. So occasionally there are failures in post submit that "should" have gotten caught in presubmit, but the branch was too outdated to be tested in the failing state. But I don't think that's the main problem here.

[jmagman]

Is this a duplicate of #15803?

[mklim]

I think this has a little more information about the current state of the world than that one, it was written before we had any checks at all. But having both seems redundant. I'll close the older in favor of this one.

[stuartmorgan]

We're validating across the two files now, so closing as fixed.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.