-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Wait for LUCI test checkin in release
#4911
Conversation
Avoid the possibilty of the `release` action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up.
@godofredoc Ping; can you verify that this is what you had in mind for this change? |
@godofredoc Ping on this trivial review. |
Taking a look.
Done, sorry for the delay! |
auto label is removed for flutter/packages/4911, due to - The status or check suite Linux_android android_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@d0e9a0e...e2ac440 2023-10-01 [email protected] Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044) 2023-10-01 [email protected] [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705) 2023-09-30 [email protected] Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043) 2023-09-30 [email protected] [webview_flutter] Add a method for getting the user agent (flutter/packages#4472) 2023-09-29 [email protected] [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037) 2023-09-29 [email protected] [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911) 2023-09-29 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927) 2023-09-29 [email protected] [ci] Disable maps tests in Android emulator (flutter/packages#5003) 2023-09-29 [email protected] [camera] Dispose resources correctly on setDescription (flutter/packages#4003) 2023-09-29 [email protected] [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702) 2023-09-29 [email protected] [camera] Remove `@throw` from iOS implementation (flutter/packages#5034) 2023-09-29 [email protected] Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@d0e9a0e...e2ac440 2023-10-01 [email protected] Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044) 2023-10-01 [email protected] [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705) 2023-09-30 [email protected] Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043) 2023-09-30 [email protected] [webview_flutter] Add a method for getting the user agent (flutter/packages#4472) 2023-09-29 [email protected] [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037) 2023-09-29 [email protected] [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911) 2023-09-29 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927) 2023-09-29 [email protected] [ci] Disable maps tests in Android emulator (flutter/packages#5003) 2023-09-29 [email protected] [camera] Dispose resources correctly on setDescription (flutter/packages#4003) 2023-09-29 [email protected] [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702) 2023-09-29 [email protected] [camera] Remove `@throw` from iOS implementation (flutter/packages#5034) 2023-09-29 [email protected] Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Avoid the possibilty of the `release` action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up.
Avoid the possibilty of the
release
action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up.