Skip to content

Commit

Permalink
[ci] Wait for LUCI test checkin in release (flutter#4911)
Browse files Browse the repository at this point in the history
Avoid the possibilty of the `release` action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up.
  • Loading branch information
stuartmorgan authored Sep 29, 2023
1 parent b3138a6 commit cb6c5ec
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,22 @@ jobs:
run: dart pub get
working-directory: ${{ github.workspace }}/script/tool

# The next step waits for all tests, but when there are issues with the
# hooks it can take a long time for the tests to even be registered. If
# "Wait on all tests" runs before that happens, it will pass immediately
# because there doesn't appear to be anything to wait for. To avoid that,
# explicitly wait for one LUCI test by name first.
- name: Wait for test check-in
uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812
with:
ref: ${{ github.sha }}
check-name: 'Linux ci_yaml packages roller'
repo-token: ${{ secrets.GITHUB_TOKEN }}
wait-interval: 30 # seconds
allowed-conclusions: success,neutral
# verbose:true will produce too many logs that hang github actions web UI.
verbose: false

# This workflow should be the last to run. So wait for all the other tests to succeed.
- name: Wait on all tests
uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812
Expand Down

0 comments on commit cb6c5ec

Please sign in to comment.