[webview_flutter_android] Adds Android implementation to override console log #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
approved these changes
Sep 15, 2023
Co-authored-by: Maurice Parrish <[email protected]>
…ascript_console_android
…om:baseflow/flutter_packages into feature/forward_javascript_console_android
…re/forward_javascript_console_android
…re/forward_javascript_console_android
|
@bparrishMines, took a long time to locate an error in the integration tests (accidentally kept a strong reference, where it should have been a weak reference). However that is fixed now and this PR should be ready for another review. |
bparrishMines
approved these changes
Sep 29, 2023
packages/webview_flutter/webview_flutter_android/pigeons/android_webview.dart
Outdated
Show resolved
Hide resolved
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 2, 2023
flutter/packages@d0e9a0e...e2ac440 2023-10-01 [email protected] Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044) 2023-10-01 [email protected] [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705) 2023-09-30 [email protected] Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043) 2023-09-30 [email protected] [webview_flutter] Add a method for getting the user agent (flutter/packages#4472) 2023-09-29 [email protected] [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037) 2023-09-29 [email protected] [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911) 2023-09-29 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927) 2023-09-29 [email protected] [ci] Disable maps tests in Android emulator (flutter/packages#5003) 2023-09-29 [email protected] [camera] Dispose resources correctly on setDescription (flutter/packages#4003) 2023-09-29 [email protected] [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702) 2023-09-29 [email protected] [camera] Remove `@throw` from iOS implementation (flutter/packages#5034) 2023-09-29 [email protected] Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@d0e9a0e...e2ac440 2023-10-01 [email protected] Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044) 2023-10-01 [email protected] [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705) 2023-09-30 [email protected] Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043) 2023-09-30 [email protected] [webview_flutter] Add a method for getting the user agent (flutter/packages#4472) 2023-09-29 [email protected] [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037) 2023-09-29 [email protected] [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911) 2023-09-29 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927) 2023-09-29 [email protected] [ci] Disable maps tests in Android emulator (flutter/packages#5003) 2023-09-29 [email protected] [camera] Dispose resources correctly on setDescription (flutter/packages#4003) 2023-09-29 [email protected] [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702) 2023-09-29 [email protected] [camera] Remove `@throw` from iOS implementation (flutter/packages#5034) 2023-09-29 [email protected] Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…sole log (flutter#4702) Adds the Android implementation for registering a JavaScript console callback. This will allow developers to receive JavaScript console messages in a Dart callback. This PR contains the `webview_flutter_android` specific changes from PR flutter#4541. Related issue: flutter/flutter#32908 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Android implementation for registering a JavaScript console callback. This will allow developers to receive JavaScript console messages in a Dart callback.
This PR contains the
webview_flutter_androidspecific changes from PR #4541.Related issue: flutter/flutter#32908
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.