Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .packages breakage and roll engine to 83b9a591a3d5 #106584

Merged
merged 9 commits into from
Jun 25, 2022

Conversation

bdero
Copy link
Member

@bdero bdero commented Jun 24, 2022

No description provided.

@flutter-dashboard flutter-dashboard bot added engine flutter/engine repository. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 24, 2022
@bdero bdero changed the title Fix .package breakage and roll engine to 83b9a591a3d5 Fix .packages breakage and roll engine to 83b9a591a3d5 Jun 24, 2022
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero
Copy link
Member Author

bdero commented Jun 24, 2022

This fix is turning out to be nontrivial, so going with the revert.

@bdero bdero closed this Jun 24, 2022
@bdero bdero reopened this Jun 24, 2022
@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jun 24, 2022
@bdero bdero force-pushed the engine-roll-83b9a591a3d5 branch from ed93b06 to 2b3bf2f Compare June 24, 2022 23:46
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@bdero bdero added waiting for tree to go green autosubmit Merge PR when tree becomes green via auto submit App labels Jun 25, 2022
@bdero bdero merged commit 097c162 into flutter:master Jun 25, 2022
@zanderso
Copy link
Member

Thanks, @bdero !

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 25, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
* 9508a36 Roll Dart SDK from 692562354d6d to d3b8091c30f0 (1 revision) (flutter/engine#34273)

* a2985c0 Roll Fuchsia Linux SDK from F1U6IH2Nf... to aRT7s0Yct... (flutter/engine#34251)

* 54867f3 Roll Skia from bdd0205ae470 to 4345a2ea731a (1 revision) (flutter/engine#34268)

* 98221a2 Clean up text input configuration in clearTextInputClient (flutter/engine#34209)

* b9e02cc Adds a license check shard to CI (flutter/engine#34274)

* 1daf7ba [Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion (flutter/engine#34252)

* 83b9a59 [Linux] remove duplicate clone_string() in favor of g_strdup() (flutter/engine#34031)

* Don't use .packages

* Another attempt

Co-authored-by: engine-flutter-autoroll <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine repository. See also e: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants