This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion #34252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command specifies no opinion
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Jun 23, 2022
| @@ -440,6 +440,16 @@ static bool Bind(PassBindingsCache& pass, | |||
| .zfar = v.depth_range.z_far, | |||
| }; | |||
| [encoder setViewport:viewport]; | |||
| } else { | |||
| MTLViewport viewport = { | |||
There was a problem hiding this comment.
Minor nit: You can dry this up a bit. Instead of checking if the viewport has value, then getting its value and then converting to MTLViewport in two places, you could use value_or when getting the viewport. Then you won't need branch here and the code will be more concise.
Something like:
auto v = command.viewport.value_or({GetRenderTargetSize...});
// The old code remains as is
ColdPaleLight
force-pushed
the
reset_viewport_and_scissor
branch
from
86e1f67 to
3f9a428
Compare
chinmaygarde
approved these changes
Jun 24, 2022
ColdPaleLight
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
…ase the command specifies no opinion (flutter/engine#34252)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
…ase the command specifies no opinion (flutter/engine#34252)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
…ase the command specifies no opinion (flutter/engine#34252)
bdero
added a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2022
* 9508a36 Roll Dart SDK from 692562354d6d to d3b8091c30f0 (1 revision) (flutter/engine#34273) * a2985c0 Roll Fuchsia Linux SDK from F1U6IH2Nf... to aRT7s0Yct... (flutter/engine#34251) * 54867f3 Roll Skia from bdd0205ae470 to 4345a2ea731a (1 revision) (flutter/engine#34268) * 98221a2 Clean up text input configuration in clearTextInputClient (flutter/engine#34209) * b9e02cc Adds a license check shard to CI (flutter/engine#34274) * 1daf7ba [Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion (flutter/engine#34252) * 83b9a59 [Linux] remove duplicate clone_string() in favor of g_strdup() (flutter/engine#34031) * Don't use .packages * Another attempt Co-authored-by: engine-flutter-autoroll <[email protected]>
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
* 9508a36 Roll Dart SDK from 692562354d6d to d3b8091c30f0 (1 revision) (flutter/engine#34273) * a2985c0 Roll Fuchsia Linux SDK from F1U6IH2Nf... to aRT7s0Yct... (flutter/engine#34251) * 54867f3 Roll Skia from bdd0205ae470 to 4345a2ea731a (1 revision) (flutter/engine#34268) * 98221a2 Clean up text input configuration in clearTextInputClient (flutter/engine#34209) * b9e02cc Adds a license check shard to CI (flutter/engine#34274) * 1daf7ba [Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion (flutter/engine#34252) * 83b9a59 [Linux] remove duplicate clone_string() in favor of g_strdup() (flutter/engine#34031) * Don't use .packages * Another attempt Co-authored-by: engine-flutter-autoroll <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#105936
Pre-launch Checklist
writing and running engine tests.
///).