This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] remove duplicate clone_string() in favor of g_strdup() #34031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLib's g_strdup() offers the same behavior that it returns NULL if the argument is NULL: https://docs.gtk.org/glib/func.strdup.html
dkwingsmt
approved these changes
Jun 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
bdero
added a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2022
* 9508a36 Roll Dart SDK from 692562354d6d to d3b8091c30f0 (1 revision) (flutter/engine#34273) * a2985c0 Roll Fuchsia Linux SDK from F1U6IH2Nf... to aRT7s0Yct... (flutter/engine#34251) * 54867f3 Roll Skia from bdd0205ae470 to 4345a2ea731a (1 revision) (flutter/engine#34268) * 98221a2 Clean up text input configuration in clearTextInputClient (flutter/engine#34209) * b9e02cc Adds a license check shard to CI (flutter/engine#34274) * 1daf7ba [Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion (flutter/engine#34252) * 83b9a59 [Linux] remove duplicate clone_string() in favor of g_strdup() (flutter/engine#34031) * Don't use .packages * Another attempt Co-authored-by: engine-flutter-autoroll <[email protected]>
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
* 9508a36 Roll Dart SDK from 692562354d6d to d3b8091c30f0 (1 revision) (flutter/engine#34273) * a2985c0 Roll Fuchsia Linux SDK from F1U6IH2Nf... to aRT7s0Yct... (flutter/engine#34251) * 54867f3 Roll Skia from bdd0205ae470 to 4345a2ea731a (1 revision) (flutter/engine#34268) * 98221a2 Clean up text input configuration in clearTextInputClient (flutter/engine#34209) * b9e02cc Adds a license check shard to CI (flutter/engine#34274) * 1daf7ba [Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion (flutter/engine#34252) * 83b9a59 [Linux] remove duplicate clone_string() in favor of g_strdup() (flutter/engine#34031) * Don't use .packages * Another attempt Co-authored-by: engine-flutter-autoroll <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLib's
g_strdup()offers the same behavior that it returnsNULLif the argument isNULL: https://docs.gtk.org/glib/func.strdup.htmlFor reference: gstrfuncs.c#L344-L370
Pre-launch Checklist
///).