Fix jumping when doing long press for selecting text #102270

rgevrek · 2022-04-21T03:28:38Z

If on an EditableText or SelectableText widget a text is selected, then the viewport will be scrolled to the last cursor position, but while selecting any text, the cursor gets an inactive state _cursorActive = false.
With this PR the misbehaviour of jumping to a non existent cursor will be avoided with checking for !_cursorActive to interrupt jumping to the non existing cursor.

#91464 will be resolved

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

flutter-dashboard · 2022-04-21T03:28:42Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

packages/flutter/lib/src/widgets/editable_text.dart

packages/flutter/test/widgets/editable_text_test.dart

rgevrek · 2022-04-21T21:04:50Z

Hi @LongCatIsLooong
Have you any idea to solve the check:

ci.yaml validation
.ci.yaml has failures

DETAILS
FormatException: ERROR: Mac gradle_plugin_fat_apk_test is a new builder added. it needs to be marked bringup: true

LongCatIsLooong · 2022-04-21T22:12:14Z

could you try syncing the pull request to upstream/master?

rgevrek · 2022-04-21T22:43:25Z

thank you for your hint @LongCatIsLooong

packages/flutter/test/widgets/editable_text_test.dart

…g text

LongCatIsLooong

LGTM. Thanks for the fix!

chunhtai

LGTM

…/flutter#102270)

This reverts commit 6ea4aef.

…#102270)" This reverts commit 6ea4aef.

…" (#103142) This reverts commit 6ea4aef.

…#102270)" (flutter#103142) This reverts commit 6ea4aef.

) * Revert "Fix jumping when doing long press for selecting text (#102270)" (#103142) This reverts commit 6ea4aef. * Roll engine with Cps * Fix engine hash

…ter#103206) * Revert "Fix jumping when doing long press for selecting text (flutter#102270)" (flutter#103142) This reverts commit 6ea4aef. * Roll engine with Cps * Fix engine hash

…#103374) * [flutter_releases] Cherry pick flutter-2.13-candidate.7 changes (#103206) * Revert "Fix jumping when doing long press for selecting text (#102270)" (#103142) This reverts commit 6ea4aef. * Roll engine with Cps * Fix engine hash * [flutter_releases] partial revert of repaint boundary change (#102962) (#103214) Co-authored-by: Jonah Williams <[email protected]> * [flutter_releases] remove assert on markNeedsCompositingBitsUpdate #103227 (#103225) Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Jonah Williams <[email protected]>

S-Man42 · 2022-09-20T13:09:22Z

Is there any chance ti get this live? I still have the problem. However, do I understand the last message correctly, that you fix has been removed?

rgevrek · 2022-09-20T13:15:14Z

Is there any chance ti get this live? I still have the problem. However, do I understand the last message correctly, that you fix has been removed?

@S-Man42, yes the fix is removed from master due to Google internal pipeline errors. @LongCatIsLooong is taking care and would fix.

dtq · 2022-11-23T17:06:35Z

Would it be possible to have this hotfixed into 3.3.x stable? This issue is effecting a large number of our production users.

arianneorpilla · 2023-04-30T13:13:04Z

It's now April 2023 and I am still experiencing this issue... I still sometimes view the StackOverflow thread on this issue and go to this thread almost habitually just to find out if there are any updates on this fix being merged back to stable.

Some of us rely on CI/CD pipelines that build with stable and we can't rely on custom forks of Flutter for one or two lines of code deletions in editable_text.dart...

Is it possible I could follow up on a status for this fix being added back to stable? This is really weird and annoying behaviour...

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Apr 21, 2022

LongCatIsLooong reviewed Apr 21, 2022

View reviewed changes

rgevrek closed this Apr 21, 2022

#91464 fix jumping when doing long press for selecting text

81fcf65

rgevrek reopened this Apr 21, 2022

LongCatIsLooong reviewed Apr 21, 2022

View reviewed changes

packages/flutter/test/widgets/editable_text_test.dart Show resolved Hide resolved

#91464 code review for fix jumping when doing long press for selectin…

01e0761

…g text

LongCatIsLooong approved these changes Apr 22, 2022

View reviewed changes

chunhtai approved these changes Apr 22, 2022

View reviewed changes

chunhtai added the waiting for tree to go green label Apr 22, 2022

fluttergithubbot merged commit 6ea4aef into flutter:master Apr 22, 2022

engine-flutter-autoroll mentioned this pull request Apr 22, 2022

Roll Flutter from 1ba573b758dc to a3a9a23e46f3 (2 revisions) flutter/packages#1573

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

0d6fe72

…/flutter#102270)

rgevrek deleted the fix_jump_away_while_selecting branch April 22, 2022 22:41

engine-flutter-autoroll mentioned this pull request Apr 22, 2022

Roll Flutter from 1b58a593deac to 5a3e10047f84 (40 revisions) flutter/plugins#5343

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

7614860

…/flutter#102270)

engine-flutter-autoroll mentioned this pull request Apr 23, 2022

Roll Flutter from 1b58a593deac to 2c60d2c9152d (41 revisions) flutter/plugins#5344

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

f50fcac

…/flutter#102270)

engine-flutter-autoroll mentioned this pull request Apr 23, 2022

Roll Flutter from 1b58a593deac to e32dbbab4300 (42 revisions) flutter/plugins#5345

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

e11b517

…/flutter#102270)

engine-flutter-autoroll mentioned this pull request Apr 23, 2022

Roll Flutter from 1b58a593deac to d25116921eb7 (43 revisions) flutter/plugins#5346

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

48e4cb9

…/flutter#102270)

engine-flutter-autoroll mentioned this pull request Apr 23, 2022

Roll Flutter from 1b58a593deac to 751d9041fdb9 (44 revisions) flutter/plugins#5347

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 23, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

e5e0646

…/flutter#102270)

engine-flutter-autoroll mentioned this pull request Apr 23, 2022

Roll Flutter from 1b58a593deac to 751d9041fdb9 (44 revisions) flutter/plugins#5348

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

0f9ade0

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

7b16e83

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

67a9d09

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

db01063

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

c8365ea

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

778199b

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

fbeef6f

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

d6611a7

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

7bd47c2

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

0387a08

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

6755217

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

8f2e941

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

f6a41aa

…/flutter#102270)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022

6ea4aef Fix jumping when doing long press for selecting text (flutter…

b8f699f

…/flutter#102270)

egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022

Fix jumping when doing long press for selecting text (flutter#102270)

7be54de

CaseyHillers added a commit that referenced this pull request May 5, 2022

Revert "Fix jumping when doing long press for selecting text (#102270)"

26d11d0

This reverts commit 6ea4aef.

CaseyHillers mentioned this pull request May 5, 2022

Revert "Fix jumping when doing long press for selecting text" #103141

Merged

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 5, 2022

Revert "Fix jumping when doing long press for selecting text (flutter…

d33fbd0

…#102270)" This reverts commit 6ea4aef.

CaseyHillers pushed a commit that referenced this pull request May 5, 2022

Revert "Fix jumping when doing long press for selecting text (#102270)…

c50edbd

…" (#103142) This reverts commit 6ea4aef.

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 6, 2022

Revert "Fix jumping when doing long press for selecting text (flutter…

2b2d193

…#102270)" (flutter#103142) This reverts commit 6ea4aef.

muditatandon mentioned this pull request May 9, 2022

[flutter_releases] Cherry pick flutter-2.13-candidate.7 changes (#10… #103374

Merged

8 tasks

S-Man42 mentioned this pull request Sep 20, 2022

[SelectableText widget] Jumpy scrolling when doing long press gesture to select text #91464

Closed

arianneorpilla mentioned this pull request Jun 7, 2023

Automatically scrolling to the top when trying to copy? arianneorpilla/jidoujisho#252

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix jumping when doing long press for selecting text #102270

Fix jumping when doing long press for selecting text #102270

rgevrek commented Apr 21, 2022 •

edited

Loading

flutter-dashboard bot commented Apr 21, 2022

rgevrek commented Apr 21, 2022 •

edited

Loading

LongCatIsLooong commented Apr 21, 2022

rgevrek commented Apr 21, 2022

LongCatIsLooong left a comment

chunhtai left a comment

S-Man42 commented Sep 20, 2022

rgevrek commented Sep 20, 2022

dtq commented Nov 23, 2022

arianneorpilla commented Apr 30, 2023

Fix jumping when doing long press for selecting text #102270

Fix jumping when doing long press for selecting text #102270

Conversation

rgevrek commented Apr 21, 2022 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Apr 21, 2022

rgevrek commented Apr 21, 2022 • edited Loading

LongCatIsLooong commented Apr 21, 2022

rgevrek commented Apr 21, 2022

LongCatIsLooong left a comment

Choose a reason for hiding this comment

chunhtai left a comment

Choose a reason for hiding this comment

S-Man42 commented Sep 20, 2022

rgevrek commented Sep 20, 2022

dtq commented Nov 23, 2022

arianneorpilla commented Apr 30, 2023

rgevrek commented Apr 21, 2022 •

edited

Loading

rgevrek commented Apr 21, 2022 •

edited

Loading