Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix jumping when doing long press for selecting text" #103141

Merged
merged 1 commit into from
May 5, 2022
Merged

Revert "Fix jumping when doing long press for selecting text" #103141

merged 1 commit into from
May 5, 2022

Conversation

CaseyHillers
Copy link
Contributor

Reverts #102270

This broke internal google tests

Googlers, see b/230165332

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 5, 2022
zanderso
zanderso approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a minimal reproduction of the failing test that we can include in flutter/flutter CI?

@zanderso
Copy link
Member

zanderso commented May 5, 2022

The internal issue is closed, noting that the changes are acceptable, so I don't understand why a revert is needed.

@CaseyHillers
Copy link
Contributor Author

I've added more context to the internal bug. I defer to @LongCatIsLooong and @chunhtai but I suspect we could send a g3fix since this was a single test failing.

@fluttergithubbot fluttergithubbot merged commit 603eb82 into master May 5, 2022
@fluttergithubbot fluttergithubbot deleted the revert-102270-fix_jump_away_while_selecting branch May 5, 2022 19:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2022
@engine-flutter-autoroll
603eb82 Revert "Fix jumping when doing long press for selecting text" (…
5e6d187 
…flutter/flutter#103141)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 5, 2022
@engine-flutter-autoroll
603eb82 Revert "Fix jumping when doing long press for selecting text" (…
47b9ce9 
…flutter/flutter#103141)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 16, 2022
Revert "Fix jumping when doing long press for selecting text" (flutte…
3e3208f 
…r#103141)
CaseyHillers pushed a commit that referenced this pull request May 16, 2022
@jonahwilliams
[flutter_releases] Framework cherry-picks (#103923)
0b900a3 
* [flutter_releases] Roll engine to 2b14309d

* remove assert on markNeedsCompositingBitsUpdate (#103227)

* partial revert of repaint boundary change (#102962)

* Revert "Fix jumping when doing long press for selecting text" (#103141)

Co-authored-by: Jonah Williams <[email protected]>
@rgevrek
Copy link
Contributor

rgevrek commented Jun 19, 2022 •
edited
Loading

Hi @CaseyHillers
Why we have to revert the fix or is it fixed otherwise? With the bug, we are not able to use a selectable RichText which has a size taller than the screen size.
Simple scrollable rich texts, e.g. e-books, e-reader, news etc. are buggy with existing revision.

@CaseyHillers
Copy link
Contributor Author

@rgevrek please coordinate the reland with @LongCatIsLooong and @chunhtai. The internal test failed as it has a hard coded assumption that inactive cursors allow jumping to. This is a test issue that should be fixed, and I don't see anything wrong with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaseyHillers @zanderso @rgevrek @fluttergithubbot