This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[ios] reland "[ios_platform_view] MaskView pool to reuse maskViews. #38989" #39630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
force-pushed
the
maskview_pool_reland
branch
from
4bbf646 to
55b28d3
Compare
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2023
…120920) * 9ee3221d0 [Impeller] align SSBOs to 16 bytes to fix iOS shader validation issue. (flutter/engine#39654) * 65a79237f Roll Dart SDK from 09361aea2ca8 to 3ec7f1f92216 (1 revision) (flutter/engine#39686) * e213d1c5c Uses `int64_t` instead of `int` for the |view_id| parameter. (flutter/engine#39618) * 94e33ae50 test (flutter/engine#39630) * bddfc1c4d [Impeller] Match position attribute name across runtime effect stages (flutter/engine#39552)
|
Original PR this was supposed to reland (but didn't?) #38989 |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR caused a bug reported by b/268403088
The bug is due to the maskView's drawing not being reset after re-used.
Fixes b/268403088
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.