Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Uses int64_t instead of int for the |view_id| parameter. #39618

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Uses int64_t instead of int for the |view_id| parameter. #39618

merged 1 commit into from
Feb 16, 2023

Conversation

0xZOne
Copy link
Member

@0xZOne 0xZOne commented Feb 14, 2023 •
edited
Loading

Related issue: flutter/flutter#120256

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@0xZOne 0xZOne marked this pull request as draft February 14, 2023 09:41
@0xZOne 0xZOne changed the title Uses int64_t instead of int for the |viewId| parameter. Uses int64_t instead of int for the |view_id| parameter. Feb 14, 2023
@0xZOne 0xZOne marked this pull request as ready for review February 14, 2023 10:49
@0xZOne 0xZOne requested a review from stuartmorgan February 14, 2023 10:50
@0xZOne 0xZOne mentioned this pull request Feb 15, 2023
Open
4 tasks
@camsim99
Copy link
Contributor

camsim99 commented Feb 16, 2023 •
edited
Loading

@jmagman can you find a reviewer for this? Just FYI, this is also an issue on Android: #39476

jmagman
jmagman approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 16, 2023
@auto-submit auto-submit bot merged commit e213d1c into flutter:main Feb 16, 2023
@camsim99 camsim99 mentioned this pull request Feb 16, 2023
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2023
@engine-flutter-autoroll
e213d1c5c Uses int64_t instead of int for the |view_id| parameter. (
3d9265b 
flutter/engine#39618)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 4a90fbcd6901 to bddfc1c4dcaa (5 revisions) (#…
229d70e 
…120920)

* 9ee3221d0 [Impeller] align SSBOs to 16 bytes to fix iOS shader validation issue. (flutter/engine#39654)

* 65a79237f Roll Dart SDK from 09361aea2ca8 to 3ec7f1f92216 (1 revision) (flutter/engine#39686)

* e213d1c5c Uses `int64_t` instead of `int` for the |view_id| parameter. (flutter/engine#39618)

* 94e33ae50 test (flutter/engine#39630)

* bddfc1c4d [Impeller] Match position attribute name across runtime effect stages (flutter/engine#39552)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API platform-android platform-fuchsia platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xZOne @camsim99 @jmagman