Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Reland "[ios_platform_view] MaskView pool to reuse maskViews" (#39608)" #40456

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Mar 20, 2023

Exact Reland #38989

The change in the PR was supposed to be re-landed in #39630 but somehow did not.

PlatformViewMutationClipRectAfterMovedTests that was added in #39630 ensures b/268403088 is not regressed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz marked this pull request as ready for review March 20, 2023 17:59
@cyanglaz cyanglaz requested a review from jmagman March 20, 2023 18:34
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot merged commit 66fec20 into flutter:main Mar 20, 2023
@cyanglaz cyanglaz deleted the reland_mask_view_pool branch March 20, 2023 20:00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants