feat: Support json type in ApproxMostFrequent function #12189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
✅ Deploy Preview for meta-velox canceled.
|
natashasehgal
changed the title
natashasehgal
changed the title
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Jan 27, 2025
Summary: Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal
force-pushed
the
export-D68287956
branch
from
f3301e9 to
d6998f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
natashasehgal
force-pushed
the
export-D68287956
branch
from
d6998f6 to
311fd98
Compare
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Jan 28, 2025
Summary: Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
natashasehgal
force-pushed
the
export-D68287956
branch
from
311fd98 to
246b99a
Compare
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Jan 28, 2025
Summary: Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Jan 28, 2025
Summary: Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal
force-pushed
the
export-D68287956
branch
from
246b99a to
16dd354
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
natashasehgal
added a commit
to natashasehgal/presto
that referenced
this pull request
Jan 28, 2025
Summary: X-link: facebookincubator/velox#12189 Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Jan 30, 2025
Summary: X-link: prestodb/presto#24450 Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Jan 31, 2025
Summary: X-link: prestodb/presto#24450 Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal
force-pushed
the
export-D68287956
branch
from
16dd354 to
9731553
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Jan 31, 2025
Summary: X-link: prestodb/presto#24450 Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal
force-pushed
the
export-D68287956
branch
from
9731553 to
d594085
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
natashasehgal
force-pushed
the
export-D68287956
branch
from
a54dcc4 to
e165d9d
Compare
natashasehgal
added a commit
to natashasehgal/velox
that referenced
this pull request
Feb 4, 2025
Summary: X-link: prestodb/presto#24450 Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
Summary: X-link: prestodb/presto#24450 Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal
force-pushed
the
export-D68287956
branch
from
e165d9d to
4a7e2c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68287956 |
amitkdutta
approved these changes
Feb 4, 2025
|
Likely #12256 has the build fix. |
|
This pull request has been merged in f6fe8a3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type.