Prestissimo ApproxMostFrequent JSON

Summary: X-link: facebookincubator/velox#12189 Prestissimo ApproxMostFrequent is not implemented for JSON. This PR adds support for JSON type. Differential Revision: D68287956
natashasehgal · Jan 28, 2025 · 724be51 · 724be51
1 parent 510024d
commit 724be51
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/presto-native-execution/presto_cpp/main/types/tests/FunctionMetadataTest.cpp b/presto-native-execution/presto_cpp/main/types/tests/FunctionMetadataTest.cpp
@@ -61,7 +61,7 @@ class FunctionMetadataTest : public ::testing::Test {
 };
 
 TEST_F(FunctionMetadataTest, approxMostFrequent) {
-  testFunction("approx_most_frequent", "ApproxMostFrequent.json", 12);
+  testFunction("approx_most_frequent", "ApproxMostFrequent.json", 14);
 }
 
 TEST_F(FunctionMetadataTest, arrayFrequency) {

diff --git a/presto-native-execution/presto_cpp/main/types/tests/data/ApproxMostFrequent.json b/presto-native-execution/presto_cpp/main/types/tests/data/ApproxMostFrequent.json
@@ -120,6 +120,26 @@
       },
       "schema": "default"
     },
+    {
+      "aggregateMetadata": {
+        "intermediateType": "row(bigint,bigint,array(json),array(bigint))",
+        "isOrderSensitive": true
+      },
+      "docString": "presto.default.approx_most_frequent",
+      "functionKind": "AGGREGATE",
+      "outputType": "map(json,bigint)",
+      "paramTypes": [
+        "bigint",
+        "json",
+        "bigint"
+      ],
+      "routineCharacteristics": {
+        "determinism": "DETERMINISTIC",
+        "language": "CPP",
+        "nullCallClause": "CALLED_ON_NULL_INPUT"
+      },
+      "schema": "default"
+    },
     {
       "aggregateMetadata": {
         "intermediateType": "row(bigint,bigint,array(boolean),array(bigint))",
@@ -239,6 +259,26 @@
         "nullCallClause": "CALLED_ON_NULL_INPUT"
       },
       "schema": "default"
+    },
+    {
+      "aggregateMetadata": {
+        "intermediateType": "row(bigint,bigint,array(json),array(bigint))",
+        "isOrderSensitive": true
+      },
+      "docString": "presto.default.approx_most_frequent",
+      "functionKind": "WINDOW",
+      "outputType": "map(json,bigint)",
+      "paramTypes": [
+        "bigint",
+        "json",
+        "bigint"
+      ],
+      "routineCharacteristics": {
+        "determinism": "DETERMINISTIC",
+        "language": "CPP",
+        "nullCallClause": "CALLED_ON_NULL_INPUT"
+      },
+      "schema": "default"
     }
   ]
 }