Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pyvelox) : Remove VELOX_BUILD_MINIMAL_WITH_DWIO #12256

Closed
wants to merge 1 commit into from

Conversation

kgpai
Copy link
Contributor

@kgpai kgpai commented Feb 4, 2025

Fixes broken pyvelox build. Turns on full set of functionality for pyvelox. In a subsequent PR I will work to reduce the scope of linked features.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
@kgpai kgpai requested a review from pedroerp February 4, 2025 22:00
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d585375
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67a28de208d88d00086d02f0

@kgpai kgpai changed the title Fix pyvelox build. Fix(pyvelox) : Fix build Feb 4, 2025
@majetideepak majetideepak changed the title Fix(pyvelox) : Fix build fix(pyvelox) : Fix build Feb 4, 2025
@majetideepak majetideepak changed the title fix(pyvelox) : Fix build build(pyvelox) : Remove VELOX_BUILD_MINIMAL_WITH_DWIO=ON Feb 4, 2025
@majetideepak majetideepak changed the title build(pyvelox) : Remove VELOX_BUILD_MINIMAL_WITH_DWIO=ON build(pyvelox): Remove VELOX_BUILD_MINIMAL_WITH_DWIO=ON Feb 4, 2025
@kgpai kgpai changed the title build(pyvelox): Remove VELOX_BUILD_MINIMAL_WITH_DWIO=ON build(pyvelox): Remove VELOX_BUILD_MINIMAL_WITH_DWIO Feb 4, 2025
@kgpai kgpai changed the title build(pyvelox): Remove VELOX_BUILD_MINIMAL_WITH_DWIO build(pyvelox) : Remove VELOX_BUILD_MINIMAL_WITH_DWIO Feb 4, 2025
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kgpai
Copy link
Contributor Author

kgpai commented Feb 4, 2025

Note the fuzzer jobs are still expected to fail since it builds against mainline which is broken.

Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 5d13c13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants