Set rocksdb_large_prefix to ON and deprecate this system variable #1322

laurynas-biveinis · 2023-06-15T08:54:59Z

This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc

luqun · 2023-06-15T16:20:04Z

storage/rocksdb/ha_rocksdb.cc

+  push_warning(thd, Sql_condition::SL_WARNING, HA_ERR_WRONG_COMMAND,
+               large_prefix_deprecated_msg);
+
+  *static_cast<bool*>(var_ptr) = *static_cast<const bool*>(save);


could we add a check that if DDSE is rocksdb, user can't turn off rocksdb_large_prefix

facebook-github-bot · 2023-06-15T19:02:11Z

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun · 2023-06-16T05:59:58Z

could you also record main.mysqld--help-notwin with your change?

This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it; 3) disable setting it to OFF if MyRocks is the DDSE. Squash with 749f1dc

facebook-github-bot · 2023-06-16T10:33:10Z

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

laurynas-biveinis · 2023-06-16T10:33:34Z

Both comments addressed, ready for review again

facebook-github-bot · 2023-06-16T15:55:55Z

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc Pull Request resolved: #1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc

…tem variable Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc Pull Request resolved: facebook#1322 GitHub Author: Laurynas Biveinis <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: chni, #mysql_eng Reviewed By: chni Subscribers: [email protected] Differential Revision: https://phabricator.intern.facebook.com/D46773511 Tags: accept2ship

…cebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc Pull Request resolved: facebook#1322 Differential Revision: D46773511

…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3

) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3

…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3

Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511