-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics to catch bug 1659224 (Test main.status is unstable) #1322
Add diagnostics to catch bug 1659224 (Test main.status is unstable) #1322
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
with minor comments
@@ -319,6 +319,10 @@ let $wait_condition = | |||
# | |||
# Bug#41131 "Questions" fails to increment - ignores statements instead stored procs | |||
# | |||
SET GLOBAL log_output = 'TABLE'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be store the value of log_output
here as well
SET @old_log_output = @@GLOBAL.log_output;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is already done by the surrounding testcase, so I only restore to what the testcase sets it to previously. But what you suggest is more robust if the surrounding testcase changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, the PR is already approved
disconnect con1; | ||
connection default; | ||
DROP PROCEDURE p1; | ||
DROP FUNCTION f1; | ||
SET GLOBAL log_output = 'FILE'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restore it here
Dump the general log in case executing "SELECT f1(); CALL p1();" results in a different delta of Queries status variable than expected.
9235eeb
to
22952a1
Compare
Addressed review comments, http://jenkins.percona.com/job/percona-server-5.6-param/1620/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
…rcona#1322) Upstream commit ID: facebook/mysql-5.6@e4751ca PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Squash with 749f1dc5ef0327e55616441b399000510db9a54d Pull Request resolved: facebook/mysql-5.6#1322 Differential Revision: D46773511 fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
Dump the general log in case executing "SELECT f1(); CALL p1();"
results in a different delta of Queries status variable than
expected.
http://jenkins.percona.com/job/percona-server-5.6-param/1609/