Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics to catch bug 1659224 (Test main.status is unstable) #1322

Merged

Conversation

laurynas-biveinis
Copy link
Contributor

Dump the general log in case executing "SELECT f1(); CALL p1();"
results in a different delta of Queries status variable than
expected.

http://jenkins.percona.com/job/percona-server-5.6-param/1609/

@robgolebiowski
Copy link
Contributor

LGTM

Copy link
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
with minor comments

@@ -319,6 +319,10 @@ let $wait_condition =
#
# Bug#41131 "Questions" fails to increment - ignores statements instead stored procs
#
SET GLOBAL log_output = 'TABLE';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be store the value of log_output here as well

SET @old_log_output = @@GLOBAL.log_output;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is already done by the surrounding testcase, so I only restore to what the testcase sets it to previously. But what you suggest is more robust if the surrounding testcase changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, the PR is already approved

disconnect con1;
connection default;
DROP PROCEDURE p1;
DROP FUNCTION f1;
SET GLOBAL log_output = 'FILE';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore it here

Dump the general log in case executing "SELECT f1(); CALL p1();"
results in a different delta of Queries status variable than
expected.
@laurynas-biveinis
Copy link
Contributor Author

Addressed review comments, http://jenkins.percona.com/job/percona-server-5.6-param/1620/

Copy link
Contributor

@robgolebiowski robgolebiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurynas-biveinis laurynas-biveinis merged commit 0867c67 into percona:5.6 Feb 1, 2017
@laurynas-biveinis laurynas-biveinis deleted the bug1659224-diag-5.6 branch February 1, 2017 14:57
inikep pushed a commit to inikep/percona-server that referenced this pull request Dec 20, 2023
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Dec 20, 2023
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Dec 21, 2023
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Jan 15, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit that referenced this pull request Jan 17, 2024
)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Jan 17, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Jan 17, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Feb 8, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Feb 9, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Feb 9, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Feb 12, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 12, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 12, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 12, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 15, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 15, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 15, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 15, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 15, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 15, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request Apr 29, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request May 13, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request May 24, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
oleksandr-kachan pushed a commit to oleksandr-kachan/percona-server that referenced this pull request May 27, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request May 31, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 5, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 10, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 12, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
VarunNagaraju pushed a commit to VarunNagaraju/percona-server that referenced this pull request Jun 12, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Jul 25, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Jul 30, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Aug 21, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Aug 28, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Aug 30, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit that referenced this pull request Sep 23, 2024
)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit that referenced this pull request Sep 25, 2024
)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Sep 25, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Oct 17, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Oct 17, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
dlenev pushed a commit to dlenev/percona-server that referenced this pull request Oct 22, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Oct 28, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit that referenced this pull request Oct 30, 2024
)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 11, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 14, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 14, 2024
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Jan 23, 2025
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Jan 23, 2025
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
lukin-oleksiy pushed a commit to lukin-oleksiy/percona-server that referenced this pull request Jan 27, 2025
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
inikep pushed a commit to inikep/percona-server that referenced this pull request Jan 27, 2025
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
lukin-oleksiy pushed a commit to lukin-oleksiy/percona-server that referenced this pull request Jan 29, 2025
…rcona#1322)

Upstream commit ID: facebook/mysql-5.6@e4751ca
PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951)

Summary:
This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it.

Squash with 749f1dc5ef0327e55616441b399000510db9a54d

Pull Request resolved: facebook/mysql-5.6#1322

Differential Revision: D46773511

fbshipit-source-id: f7b43bc6db767baa8803fa6932e3592d23464fd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants