-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rocksdb-large-prefix sysvar #1397
Closed
laurynas-biveinis
wants to merge
1
commit into
facebook:fb-mysql-8.0.32
from
laurynas-biveinis:rm-myr-large-prefix
Closed
Remove rocksdb-large-prefix sysvar #1397
laurynas-biveinis
wants to merge
1
commit into
facebook:fb-mysql-8.0.32
from
laurynas-biveinis:rm-myr-large-prefix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was deprecated in 8.0.28.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
committed |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
sunxiayi
pushed a commit
to sunxiayi/mysql-5.6
that referenced
this pull request
Apr 30, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 GitHub Author: Laurynas Biveinis <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: mung, #mysql_eng Reviewed By: mung Differential Revision: https://phabricator.intern.facebook.com/D51635623
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 17, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 30, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
Summary: It was deprecated in 8.0.28. Pull Request resolved: facebook#1397 Differential Revision: D51635623 fbshipit-source-id: 302a39f ------------------------------------------------------------------------------- Set rocksdb_large_prefix to ON and deprecate this system variable (facebook#1322) Summary: This variable was introduced to mirror innodb_large_prefix, which was deprecated in 5.7 and removed in 8.0, and no longer serves any real purpose, nor there is anything to gain with its 'OFF' setting, which is also incompatible with the data dictionary schema. Thus 1) change the default to 'ON'; 2) deprecate it. Pull Request resolved: facebook#1322 Differential Revision: D46773511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was deprecated in 8.0.28.