This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Allow to configure noCache option for openshift docker build strategy #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
============================================
+ Coverage 35.91% 35.99% +0.07%
- Complexity 1103 1105 +2
============================================
Files 175 175
Lines 9914 9920 +6
Branches 1646 1648 +2
============================================
+ Hits 3561 3571 +10
+ Misses 5939 5933 -6
- Partials 414 416 +2 |
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
============================================
+ Coverage 35.88% 35.96% +0.07%
- Complexity 1103 1105 +2
============================================
Files 175 175
Lines 9924 9930 +6
Branches 1647 1649 +2
============================================
+ Hits 3561 3571 +10
+ Misses 5949 5943 -6
- Partials 414 416 +2 |
|
@bohmber : Looks good, Thanks. Could you please add a line to CHANGELOG.md about this change? |
rohanKanojia
added
the
pr/changelog-entry-please
added changelog entry Signed-off-by: bohmber <[email protected]>
rohanKanojia
approved these changes
Jan 2, 2019
devang-gaur
suggested changes
Jan 4, 2019
There was a problem hiding this comment.
@bohmber It would look real clean if you squash into a single commit.
Everything else LGTM. Just a minor change requested.
|
@rohanKanojia changelog added |
|
@dev-gaur you can do the squash during merge? |
added changelog entry Signed-off-by: bohmber <[email protected]>
Signed-off-by: bohmber <[email protected]>
|
@bohmber Yes I am going to squash at merge time, thank you very much. |
lordofthejars
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
https://docs.openshift.com/container-platform/3.6/dev_guide/builds/build_strategies.html#no-cache
Signed-off-by: bohmber [email protected]