Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Add skip options to goals #732

Closed
rhuss opened this issue Dec 13, 2016 · 4 comments · Fixed by #1471
Closed

Add skip options to goals #732

rhuss opened this issue Dec 13, 2016 · 4 comments · Fixed by #1471
Assignees
Labels
cat/feature Feature request cat/starter Easy issue, ideally for starting with fabric-maven-plugin

Comments

@rhuss
Copy link
Contributor

rhuss commented Dec 13, 2016

Description

Similar in spirit to the skip goals of d-m-p, fabric8 should support options to skip certain goals:

  • resource (fabric8.skip.resource)
  • build (already supported via docker.skip.build, should have a correspondent fabric8.skip.build)
  • push (already supported via docker.skip.push, should have a correspondent fabric8.skip.push)
  • apply (fabric8.skip.apply)
  • deploy (fabric8.skip.deploy)
@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue/PR considered to be stale label Oct 4, 2018
@rhuss
Copy link
Contributor Author

rhuss commented Oct 5, 2018

Nice starter task which should be implemented to guarantee consistency.

@stale stale bot removed the status/stale Issue/PR considered to be stale label Oct 5, 2018
@rhuss rhuss added cat/feature Feature request cat/starter Easy issue, ideally for starting with fabric-maven-plugin labels Oct 5, 2018
@devang-gaur devang-gaur self-assigned this Dec 28, 2018
@devang-gaur
Copy link
Contributor

@rhuss @rohanKanojia @lordofthejars

https://github.com/fabric8io/fabric8-maven-plugin/blob/master/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/BuildMojo.java#L85

Every mojo has a skip option already..I don't follow why we need skip.build ..skip.push etc properties ?

@rohanKanojia
Copy link
Member

@dev-gaur : These properties are needed to skip only specific goals. Most people use fmp's 2-3 goals at once, for example:

mvn fabric8:resource fabric8:build

If you use -Dfabric8.skip here, both goals are going to get skipped.

rhuss pushed a commit that referenced this issue Jan 10, 2019
bohmber pushed a commit to bohmber/fabric8-maven-plugin that referenced this issue Jan 10, 2019
bohmber pushed a commit to bohmber/fabric8-maven-plugin that referenced this issue Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/feature Feature request cat/starter Easy issue, ideally for starting with fabric-maven-plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants