Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Added 'skip' options to goals. #1471

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Conversation

devang-gaur
Copy link
Contributor

fixes #732 .

@devang-gaur
Copy link
Contributor Author

Should I add some tests for this? @rhuss @rohanKanojia ?

@rohanKanojia rohanKanojia requested review from lordofthejars, rhuss and rohanKanojia and removed request for lordofthejars and rhuss December 31, 2018 14:07
@rohanKanojia
Copy link
Member

It's fine without tests in my opinion

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #1471 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1471      +/-   ##
============================================
- Coverage     35.91%   35.91%   -0.01%     
  Complexity     1103     1103              
============================================
  Files           175      175              
  Lines          9914     9924      +10     
  Branches       1646     1647       +1     
============================================
+ Hits           3561     3564       +3     
- Misses         5939     5946       +7     
  Partials        414      414

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #1471 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1471      +/-   ##
============================================
- Coverage     35.91%   35.88%   -0.04%     
  Complexity     1103     1103              
============================================
  Files           175      175              
  Lines          9914     9924      +10     
  Branches       1646     1647       +1     
============================================
  Hits           3561     3561              
- Misses         5939     5949      +10     
  Partials        414      414

@rhuss rhuss merged commit c8092ff into fabric8io:master Jan 10, 2019
bohmber pushed a commit to bohmber/fabric8-maven-plugin that referenced this pull request Jan 10, 2019
bohmber pushed a commit to bohmber/fabric8-maven-plugin that referenced this pull request Jan 10, 2019
@Ladicek
Copy link
Contributor

Ladicek commented Jun 17, 2020

I just found by accident that many options are called docker.skip.* instead of fabric8.skip.*.

@rohanKanojia
Copy link
Member

Our Push and Build goals inherit Push/Build goals from DMP. Do you think those options are being propagated here?

@Ladicek
Copy link
Contributor

Ladicek commented Jun 17, 2020

I don't know about that. I see that this pull request includes a bunch of parameters named docker.skip.*, even though the classes are in io.fabric8.maven.plugin.

@rohanKanojia
Copy link
Member

ah, yeah. I can see it now 👓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skip options to goals
4 participants