This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should I add some tests for this? @rhuss @rohanKanojia ? |
rohanKanojia
requested review from
lordofthejars,
rhuss and
rohanKanojia
and removed request for
lordofthejars and
rhuss
December 31, 2018 14:07
It's fine without tests in my opinion |
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
============================================
- Coverage 35.91% 35.91% -0.01%
Complexity 1103 1103
============================================
Files 175 175
Lines 9914 9924 +10
Branches 1646 1647 +1
============================================
+ Hits 3561 3564 +3
- Misses 5939 5946 +7
Partials 414 414 |
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
============================================
- Coverage 35.91% 35.88% -0.04%
Complexity 1103 1103
============================================
Files 175 175
Lines 9914 9924 +10
Branches 1646 1647 +1
============================================
Hits 3561 3561
- Misses 5939 5949 +10
Partials 414 414 |
rohanKanojia
reviewed
Jan 3, 2019
bohmber
pushed a commit
to bohmber/fabric8-maven-plugin
that referenced
this pull request
Jan 10, 2019
bohmber
pushed a commit
to bohmber/fabric8-maven-plugin
that referenced
this pull request
Jan 10, 2019
I just found by accident that many options are called |
Our Push and Build goals inherit Push/Build goals from DMP. Do you think those options are being propagated here? |
I don't know about that. I see that this pull request includes a bunch of parameters named |
ah, yeah. I can see it now 👓 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #732 .