EZP-31415: Impl. composite & sibling criterion #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
aggregate_criterion
branch
2 times, most recently
from
7159ae5 to
ce46385
Compare
4 tasks
webhdx
approved these changes
Feb 27, 2020
|
Are you going to implement REST counterpart for it? |
This was referenced Feb 27, 2020
|
2 tasks
alongosz
requested changes
Mar 6, 2020
eZ/Publish/Core/Search/Legacy/Content/Common/Gateway/CriterionHandler/AggregateCriterion.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/settings/search_engines/legacy/criterion_handlers_common.yml
Outdated
Show resolved
Hide resolved
adamwojs
changed the title
alongosz
reviewed
Mar 10, 2020
eZ/Publish/API/Repository/Values/Content/Query/Criterion/Sibling.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
Mar 10, 2020
micszo
approved these changes
Mar 12, 2020
|
@adamwojs could you rebase? |
adamwojs
force-pushed
the
aggregate_criterion
branch
from
623be7e to
ca14c99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master\eZ\Publish\API\Repository\Values\Content\Query\Criterion\CompositeCriterionis a base implementation for search criteria which are created from the composition of existing ones.Criteria based on
CompositeCriteriondoesn't need specific implementation of\eZ\Publish\Core\Search\Legacy\Content\Common\Gateway\CriterionHandlerorEzSystems\EzPlatformSolrSearchEngine\Query\CriterionVisitor.See
\eZ\Publish\API\Repository\Values\Content\Query\Criterion\Siblingas an example.TODO:
$ composer fix-cs).