Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31415: Impl. criterion visitor for CompositeCriterion #170

Merged
merged 4 commits into from
Mar 12, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Feb 27, 2020

Question Answer
JIRA issue EZP-31415
Requires ezsystems/ezpublish-kernel#2958
Bug/Improvement no
New feature yes
Target version master
BC breaks no
Tests pass yes
Doc needed yes

Description

Impl. criterion visitor for eZ\Publish\API\Repository\Values\Content\Query\Criterion\CompositeCriterion. See ezsystems/ezpublish-kernel#2958

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs self-assigned this Feb 27, 2020
…es\Content\Query\Criterion\AggregateCriterion
@adamwojs adamwojs force-pushed the aggregate_criterion branch from 7388e1c to 0fa0578 Compare February 27, 2020 12:15
@adamwojs adamwojs changed the title EZP-31415: Impl. criterion visitor for eZ\Publish\API\Repository\Values\Content\Query\Criterion\AggregateCriterion EZP-31415: Impl. criterion visitor for AggregateCriterion Feb 27, 2020
@adamwojs adamwojs changed the title EZP-31415: Impl. criterion visitor for AggregateCriterion EZP-31415: Impl. criterion visitor for CompositeCriterion Mar 11, 2020
@micszo micszo self-assigned this Mar 12, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micszo micszo removed their assignment Mar 12, 2020
@adamwojs adamwojs merged commit d07e168 into master Mar 12, 2020
@adamwojs adamwojs deleted the aggregate_criterion branch March 12, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants