-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31420: Deleted translation from Solr when deleted from Version #173
Conversation
…nt store unused document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that change be reflected in the test? //ref: https://github.com/ezsystems/ezplatform-solr-search-engine/blob/1.7/tests/lib/Slot/RemoveTranslationTest.php#L52
…slation document by language code and content id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, but can we add tests for this somehow?
Oh, we need to handle DeleteTranslation as well right? As RemoveTranslation seems to be the deprecated one if I read @alongosz's master PR right. |
Yes, RemoveTranslationSignal is emitted for BC. You could actually handle both RemoveTranslationSignal and DeleteTranslationSignal in one single DeleteTranslationSlot. Don't remember how it's handled on upper branch with Events though. |
…ecting into Search Engine query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, but as I said in ezsystems/ezpublish-kernel#3013 (review) I need to see a merge up plan, probably for 3.0 branch here (but including merge as-is to 2.0 due to gitflow).
Solr Slot moved to kernel event, so any more changes in 3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so if Kernel handles everything in eZ Platform v3.0, then +1 :)
You can merge it up. |
1,7
Description
Depends on: ezsystems/ezpublish-kernel#3013
Removing a content translation does not remove the associated SolR documents
TODO: