EZP-31420: Deleted translation from Solr when deleted from Version #173
Conversation
…nt store unused document
There was a problem hiding this comment.
Shouldn't that change be reflected in the test? //ref: https://github.com/ezsystems/ezplatform-solr-search-engine/blob/1.7/tests/lib/Slot/RemoveTranslationTest.php#L52
…slation document by language code and content id
|
Oh, we need to handle DeleteTranslation as well right? As RemoveTranslation seems to be the deprecated one if I read @alongosz's master PR right. |
|
Yes, RemoveTranslationSignal is emitted for BC. You could actually handle both RemoveTranslationSignal and DeleteTranslationSignal in one single DeleteTranslationSlot. Don't remember how it's handled on upper branch with Events though. |
…ecting into Search Engine query
There was a problem hiding this comment.
+1, but as I said in ezsystems/ezpublish-kernel#3013 (review) I need to see a merge up plan, probably for 3.0 branch here (but including merge as-is to 2.0 due to gitflow).
Solr Slot moved to kernel event, so any more changes in 3.0 |
alongosz
changed the title
|
You can merge it up. |
1,7Description
Depends on: ezsystems/ezpublish-kernel#3013
Removing a content translation does not remove the associated SolR documents
TODO: