Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29984: Fix LIKE support for * as wildcard across engines, deprecate % usage #2517

Merged
merged 17 commits into from
Feb 1, 2019
Merged

EZP-29984: Fix LIKE support for * as wildcard across engines, deprecate % usage #2517

merged 17 commits into from
Feb 1, 2019

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Jan 7, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-29984
Bug/Improvement yes
Target version 6.13 and up
BC breaks no
Tests pass yes
Doc needed Could be nice with more doc around this yes, it's somewhat undocumented

Does:

  • Fixes Operator::LIKE support for being able to use * as wildcard in Field criterion value
  • Deprecate unintended support for using % for this when using LegacySearchEngine
  • Add missing (minimal) Field Criteria & SortingClause support for Author, RelationList and RichText FieldTypes when using LegacySearchEngine

TODO:

@andrerom andrerom changed the base branch from master to 6.13 January 7, 2019 20:27
@ezrobot

This comment has been minimized.

Sign in to view
@ezrobot

This comment has been minimized.

Sign in to view
@andrerom andrerom mentioned this pull request Jan 9, 2019
Merged
2 tasks
@andrerom andrerom requested review from alongosz and kmadejski January 9, 2019 11:50
@andrerom
Copy link
Contributor Author

andrerom commented Jan 9, 2019 •
edited
Loading

Review notes:

  • On MERGE: Drop e5131cf
  • Removes some unused / deprecated tests cases while on it, can alternatively do that as separate commit on merge

@ezrobot

This comment has been minimized.

Sign in to view
@andrerom andrerom changed the title EZP-29984: Add LIKE support for * as wildcard across engines, deprecate % usage EZP-29984: Fix LIKE support for * as wildcard across engines, deprecate % usage Jan 9, 2019
@andrerom andrerom requested a review from adamwojs January 9, 2019 16:12
@andrerom
Copy link
Contributor Author

All green now @alongosz, @adamwojs, .. ;)

@andrerom andrerom requested a review from ViniTou January 16, 2019 20:52
kmadejski
kmadejski approved these changes Jan 18, 2019
View reviewed changes
eZ/Publish/Core/FieldType/RelationList/Type.php Outdated
@@ -205,15 +205,16 @@ protected function checkValueStructure(BaseValue $value)

/**
* Returns information for FieldValue->$sortKey relevant to the field type.
* For this FieldType, the related object's name is returned.
*
* For this FieldType, the related object's name is returned, separated by ",".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be something like:
For this FieldType, the related objects IDs are returned, separated by ","., shouldn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@andrerom andrerom merged commit 7129d21 into 6.13 Feb 1, 2019
@andrerom andrerom deleted the EZP-29984 branch February 1, 2019 08:57
@andrerom
Copy link
Contributor Author

andrerom commented Feb 1, 2019

Merged to moved forward on ezsystems/ezplatform-solr-search-engine#128

andrerom added a commit to microblau/ezplatform-xmltext-fieldtype that referenced this pull request Oct 3, 2019
@andrerom
Port over logic from RichText to align
0cd85f8 
Port over logic from: ezsystems/ezpublish-kernel#2517
andrerom added a commit to ezsystems/ezplatform-richtext that referenced this pull request Dec 23, 2019
@andrerom
Port fix for EZP-29958 and EZP-29984 from kernel
4134ebe 
Ports over fixes for:
- EZP-29984: Fix LIKE support for * as wildcard across engines, deprecate % usage
- ezsystems/ezpublish-kernel#2517

Which also happens to align RichText with how XmlText had been fixed for:
- "Creating paragraph longer than 32766 bytes in RichText Editor will fail with Solr Error"
- https://jira.ez.no/browse/EZP-29958
andrerom added a commit to ezsystems/ezplatform-richtext that referenced this pull request Dec 23, 2019
@andrerom
Port fix for EZP-29958 and EZP-29984 from kernel
e27a3a5 
Ports over fixes for:
- EZP-29984: Fix LIKE support for * as wildcard across engines, deprecate % usage
- ezsystems/ezpublish-kernel#2517

Which also happens to align RichText with how XmlText had been fixed for:
- "Creating paragraph longer than 32766 bytes in RichText Editor will fail with Solr Error"
- https://jira.ez.no/browse/EZP-29958
@andrerom andrerom mentioned this pull request Dec 23, 2019
Merged
4 tasks
andrerom added a commit to ezsystems/ezplatform-richtext that referenced this pull request Dec 23, 2019
@andrerom
Port fix for EZP-29958 & EZP-29984 from kernel
5a279ff 
Ports over fixes for:
- EZP-29984: Fix LIKE support for * as wildcard across engines, deprecate % usage
- ezsystems/ezpublish-kernel#2517

Which also happens to align RichText with how XmlText had been fixed for:
- "Creating paragraph longer than 32766 bytes in RichText Editor will fail with Solr Error"
- https://jira.ez.no/browse/EZP-29958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@kmadejski kmadejski kmadejski approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrerom @ezrobot @alongosz @kmadejski @ViniTou