EZP-29984: Add support for Field LIKE criterion with "*" wildcards #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
andrerom
changed the title
|
@wizhippo As you did the initial impl, your ok with a change like this on your side? |
|
@andrerom I'm good with it like this. Are we making legacy behave the same (using '%' on the start and end by default)? If not then making this behave the same for consistency may be wanted. |
|
@wizhippo It's on the todo on this. Before this can be merged, there should be PR on kernel adding integration tests and possibly adapt logic in legacySE. |
7 tasks
andrerom
changed the title
|
@wizhippo Kernel PR done and this PR adapted for it (using * now instead to align with FullText). |
ViniTou
approved these changes
Jan 17, 2019
…ch Engine Adapt SolrSE to correct support for LIKE and CONTAINS. Todo: - Open PR with API and integration test coverage for this. - CS / Adapt unit tests
alongosz
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/EZP-29984
Adapt Solr Search Engine to correct support for LIKE with wildcards using "*".
Todo: