Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported fix for EZP-29958 and EZP-29984 from kernel #95

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Ported fix for EZP-29958 and EZP-29984 from kernel #95

merged 2 commits into from
Jan 14, 2020

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Dec 23, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-29984 & EZP-29958
Bug/Improvement yes
New feature no
Target version 1.1+
BC breaks no
Tests pass yes?
Doc needed no?

Ports over fixes from:

Which also happens to align RichText with how XmlText had been fixed for:

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@andrerom andrerom changed the base branch from master to 1.1 December 23, 2019 13:41
@andrerom
Port fix for EZP-29958 & EZP-29984 from kernel
5a279ff 
Ports over fixes for:
- EZP-29984: Fix LIKE support for * as wildcard across engines, deprecate % usage
- ezsystems/ezpublish-kernel#2517

Which also happens to align RichText with how XmlText had been fixed for:
- "Creating paragraph longer than 32766 bytes in RichText Editor will fail with Solr Error"
- https://jira.ez.no/browse/EZP-29958
konradoboza
konradoboza approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@konradoboza konradoboza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good to me. 👍

@alongosz alongosz changed the title Port fix for EZP-29958 and EZP-29984 from kernel Ported fix for EZP-29958 and EZP-29984 from kernel Jan 8, 2020
alongosz
alongosz requested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small strict type request:

src/lib/eZ/FieldType/RichText/SearchField.php Outdated Show resolved Hide resolved
@andrerom
Copy link
Contributor Author

andrerom commented Jan 8, 2020 •
edited
Loading

Just a small strict type request:

added 👍

@micszo micszo self-assigned this Jan 10, 2020
@micszo
Copy link
Member

micszo commented Jan 13, 2020

Regarding wildcard support in ezauthor should the Email field also be covered or only the Name field?

@micszo
Copy link
Member

micszo commented Jan 13, 2020

Also I have discovered that searching for values in ezemail and ezisbn fields (regardless of wildcards) doesn't work at all, even without Solr and this change. I need to dig in JIRA if we have something for that already.

@andrerom
Copy link
Contributor Author

andrerom commented Jan 13, 2020 •
edited
Loading

Regarding wildcard support in ezauthor should the Email field also be covered or only the Name field?

In context of what changed in EZP-29984, LIKE and sort by fixes to align Solr and LegacySE for default fields, only name. email should be possible on Solr but would involve searching on custom field and not the default.

discovered that searching for values in ezemail and ezisbn fields (regardless of wildcards) doesn't work

sounds like something to report separately with affected LTS versions

@micszo
Copy link
Member

micszo commented Jan 13, 2020

Reported separately: https://jira.ez.no/browse/EZP-31287.

micszo
micszo approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.8 with diff.

@micszo micszo removed their assignment Jan 13, 2020
@andrerom andrerom merged commit 456ec0e into 1.1 Jan 14, 2020
@andrerom andrerom deleted the EZP-29958 branch January 14, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrerom @micszo @alongosz @konradoboza