Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29117: fix build #450

Merged
merged 2 commits into from
Apr 25, 2018
Merged

EZP-29117: fix build #450

merged 2 commits into from
Apr 25, 2018

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Apr 23, 2018 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-29117
Bug fix? n/a
New feature? yes (Travis notifications)
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

Two things are done here:
first commit: adjusting selector for things done in #448
second commit: adding Travis notifications for eZ Systems Polska, #travis-notifications channel (using https://docs.travis-ci.com/user/notifications#Configuring-Slack-notifications)

@mnocon mnocon changed the title [WIPEzp 29117 fix build [WIP]EZP-29117: fix build Apr 23, 2018
@mnocon mnocon changed the title [WIP]EZP-29117: fix build EZP-29117: fix build Apr 24, 2018
@mnocon mnocon requested review from m-tyrala and micszo April 24, 2018 07:13
micszo
micszo approved these changes Apr 24, 2018
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

m-tyrala
m-tyrala approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes shows that it'd be good to improve styling in Admin panel.

Approve ofc

@mnocon
Copy link
Member Author

mnocon commented Apr 25, 2018

@lserwatka this one can be merged

@lserwatka lserwatka merged commit d12baa0 into ezsystems:master Apr 25, 2018
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@tomaszszopinski
[Behat] Disabled ElementTransitionHasEndedCondition conditions (#450)
658278a 
* commented ElementTransitionHasEndedCondition conditions

* removed commented

* commented ElementTransitionHasEndedCondition conditions

removed commented

* cs fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@m-tyrala m-tyrala m-tyrala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnocon @micszo @m-tyrala @lserwatka