Skip to content

Commit

Permalink
[Behat] Disabled ElementTransitionHasEndedCondition conditions (#450)
Browse files Browse the repository at this point in the history
* commented ElementTransitionHasEndedCondition conditions

* removed commented

* commented ElementTransitionHasEndedCondition conditions

removed commented

* cs fix
  • Loading branch information
tomaszszopinski authored May 31, 2022
1 parent 1109b8e commit 658278a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
5 changes: 1 addition & 4 deletions src/lib/Behat/Component/IbexaDropdown.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,14 @@
namespace Ibexa\AdminUi\Behat\Component;

use Ibexa\Behat\Browser\Component\Component;
use Ibexa\Behat\Browser\Element\Condition\ElementTransitionHasEndedCondition;
use Ibexa\Behat\Browser\Element\Criterion\ElementTextCriterion;
use Ibexa\Behat\Browser\Locator\VisibleCSSLocator;

class IbexaDropdown extends Component
{
public function verifyIsLoaded(): void
{
$this->getHTMLPage()
->setTimeout(2)
->waitUntilCondition(new ElementTransitionHasEndedCondition($this->getHTMLPage(), $this->getLocator('isIbexaDropdownVisible')));
//TODO: check if needed
}

protected function specifyLocators(): array
Expand Down
3 changes: 0 additions & 3 deletions src/lib/Behat/Page/ContentTypeUpdatePage.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
namespace Ibexa\AdminUi\Behat\Page;

use Ibexa\Behat\Browser\Element\Condition\ElementExistsCondition;
use Ibexa\Behat\Browser\Element\Condition\ElementTransitionHasEndedCondition;
use Ibexa\Behat\Browser\Element\Criterion\ElementAttributeCriterion;
use Ibexa\Behat\Browser\Element\Criterion\ElementTextCriterion;
use Ibexa\Behat\Browser\Element\Mapper\ElementTextMapper;
Expand All @@ -33,8 +32,6 @@ public function expandLastFieldDefinition(): void
$lastFieldDefinition->mouseOver();
$lastFieldDefinition->assert()->isVisible();
$lastFieldDefinition->click();
$this->getHTMLPage()->setTimeout(5)
->waitUntilCondition(new ElementTransitionHasEndedCondition($this->getHTMLPage(), $fieldToggleLocator));
}

public function specifyLocators(): array
Expand Down

0 comments on commit 658278a

Please sign in to comment.