EZP-29117: Improve Content Type view design #448
Conversation
|
Amazing! Thanks @mikadamczyk for the improvement. |
| @@ -74,7 +74,7 @@ | |||
| color: $ez-color-base-dark; | |||
| } | |||
|
|
|||
| .ez-info-view, .ez-link-manager-view { | |||
| .ez-info-view, .ez-link-manager-view, .ez-content-type-view { | |||
There was a problem hiding this comment.
Please move it to a new line, it's more readable.
| </tr> | ||
| </thead> | ||
|
|
|
|
||
| <br /> | ||
| <br /> |
There was a problem hiding this comment.
I know it's not yours but this br looks odd. Can you check if it's needed?
mikadamczyk
force-pushed
the
EZP-29117
branch
2 times, most recently
from
ba8fc5f to
0145ae1
Compare
| @@ -74,7 +74,9 @@ | |||
| color: $ez-color-base-dark; | |||
| } | |||
|
|
|||
| .ez-info-view, .ez-link-manager-view { | |||
| .ez-info-view, | |||
There was a problem hiding this comment.
Maybe, instead of adding parent selectors you should create an instance of modifier class? It becomes to coupled to a specific context that is against BEM rules.
A thing to consider @dew326
| @@ -117,6 +119,14 @@ | |||
| } | |||
| } | |||
|
|
|||
| .ez-content-type-view { | |||
| .ez-table-field-definitions { | |||
| thead th { | |||
There was a problem hiding this comment.
Can you avoid using tag selectors? Please, create a CSS class attached to th elements and use it instead.
| <br /> | ||
| <div class="container mt-4 px-4"> | ||
| <section class="ez-fieldgroup"> | ||
| <h2 class="ez-fieldgroup-name">{{ "content_type.content_field_definitions"|trans|desc("Content field definitions") }}</h2> |
There was a problem hiding this comment.
ez-fieldgroup-name is against BEM rules. You have to improve it. I suggest converting it to: ez-fieldgroup__name
| </div> | ||
| <section class="container mt-4 px-5"> | ||
| {% for group, field_definitions in field_definitions_by_group %} | ||
| <header class="ez-table-header ez-table-header"> |
There was a problem hiding this comment.
It should be ez-table__header
|
|
||
| <table class="table ez-table-field-definitions"> |
There was a problem hiding this comment.
ez-table__field-definitions
|
ping @sunpietro |
|
|
||
| <table class="table"> | ||
| <thead> | ||
| <table class="table ez-table--list table"> |
| {{ macros.content_type_edit(content_type, content_type_group, 'btn btn-primary') }} | ||
| </div> | ||
| <header class="ez-table__header"> | ||
| <div class="ez-table-header__headline">{{ "content_type.content_type"|trans|desc("Content Type") }}</div> |
There was a problem hiding this comment.
Instead of ez-table-header__headline set ez-table__headline
EZP-29117: Improve content type view design - miko EZP-29117: Improve content type view design -miko
| width: calc(100% / 3); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .ez-table-header { |
|
@micszo can we merge it? |
Checklist:
$ composer fix-cs)