-
Notifications
You must be signed in to change notification settings - Fork 146
Conversation
docs/release_notes/trinity.rst
Outdated
@@ -4,6 +4,7 @@ Trinity | |||
Unreleased (latest source) | |||
-------------------------- | |||
|
|||
- `#485 <https://github.com/ethereum/trinity/pull/485>`_: Bugfix: Ensure Trinity shuts down if Discovery crashs unexpectedly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on grouping notes by Feature, Bugfix, Performance, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, totally. Let me fix it right away.
Yikes, looks like master is broken! |
Wait, what? Last commit on |
But that commit isn't on |
Why would a squash/rebase affect any of those lint failures? |
Because those do not exist on latest Or to put it another way, this PR, the When the time comes, we'll squash all changes into one commit, rebase on top of latest master and all issues should magically disappear under the assumption that The alternative would be rebase this branch now and then force push it but the issue description says this should be avoided.
|
Hm, but every new test run is supposed to merge with master before running tests, so it should have all the latest changes on master. It's not so much that I want to fix the problem of this PR having a ❌ -- it's that this ^ mechanism I thought should prevent the problem of testing on old PRs. If it's not solving the problem, I want to understand why and maybe try to fix it. |
I pushed my changes from the last few weeks. |
For PR #608 (not yet merged): - `#608 <https://github.com/ethereum/trinity/pull/608>`_: Tests: Run tests for Constantinople and Petersburg |
For PR #623 (not yet merged): - `#623 <https://github.com/ethereum/trinity/pull/623>`_: Tests: Optimise for faster run times |
I'm starting to clean and finish up the release notes for today's trinity release. If you have any more additions, please make a comment instead of editing the PR. |
Some rearranging to keep features, bugfixes, and performance updates together.
Wow, we clearly waited too long between releases. (I mean we already knew that, but this changelog is enormous.) |
This is the long-running PR for release notes to be included in the next release.
Community contributors are welcome to comment below with your notes, or open a PR to merge into this branch.
Coders with write access are welcome to add commits on top. Please don't force push, though: it would be sad to accidentally blow away someone else's notes.