This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Upgrade docker release to use Python 3.7 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug with the current docker image for Python 3.6. Since we support Python 3.7, the easiest fix is to just upgrade to Python 3.6 which already uses debian stretch and hence does not suffer from that bug. To be clear, this is a bug with the docker image, not Trinity or Python 3.6 in particular.
carver
pushed a commit
that referenced
this pull request
May 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Our docker image generation currently fails due to a bug with the docker debian jessie image.
How was it fixed?
The easiest way to solve this is to just build on the
python:3.7package which happens to be on debian stretch already and hence not suffer from this bug.Since Trinity supports Python 3.7 out of the box and there's no good reason to stick to Python 3.6 for the docker images, this seems to be the simplest fix (confirmed that it works).
To-Do
Cute Animal Picture