Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Switch to long-running release notes PR #442

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Switch to long-running release notes PR #442

merged 1 commit into from
Apr 29, 2019

Conversation

carver
Copy link
Contributor

@carver carver commented Mar 21, 2019

What was wrong?

Some issues with including release notes in each PR:

  • ripe for conflicts: people likely to add their own line to the beginning or end of the list
  • requires pushing ones to get the PR number, then again. Potentially wastes a whole suite of test-runs.

How was it fixed?

  • Created a new label that should go on the running PR
  • Change the notes to reference it

This should probably not merge until we have created the running PR (will do after I track down this libp2p issue that broke master)

Cute Animal Picture

put a cute animal picture link inside the parentheses

@carver carver mentioned this pull request Mar 21, 2019
Merged
@carver
Copy link
Contributor Author

carver commented Mar 21, 2019

Failure is on master, fixed by #443

@carver
Copy link
Contributor Author

carver commented Mar 21, 2019 •
edited
Loading

First example: #445

@carver carver merged commit 245adc3 into master Apr 29, 2019
@carver carver deleted the new-release-notes-process branch April 29, 2019 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carver