Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Replace removed API with public flags (fixes #498) #505

Merged
merged 3 commits into from
Jul 26, 2018
Merged

Fix: Replace removed API with public flags (fixes #498) #505

merged 3 commits into from
Jul 26, 2018

Conversation

texastoland
Copy link
Contributor

#499 rebased.

@texastoland
Copy link
Contributor Author

texastoland commented Jul 26, 2018 •
edited
Loading

Have you guys seen https://github.com/ajafff/tsutils? I checked it for my implementation. It's maintained by a prominent contributor to TypeScript with a backwards compatibility layer. Is a TypeScript rewrite on the roadmap? Would it make sense to add as a dependency?

@JamesHenry JamesHenry merged commit f1d7de3 into eslint:master Jul 26, 2018
@JamesHenry
Copy link
Member

Thanks!

A TypeScript rewrite is not on the cards, this library is maintained in accordance with ESLint's standard development stack.

@texastoland
Copy link
Contributor Author

Have you seen tsutils anyway? It could provide a baseline for backwards compatibility.

ismail-syed pushed a commit to Shopify/eslint-plugin-shopify that referenced this pull request Jul 31, 2018
@texastoland @ismail-syed
Remove inline Prettier configs (fixes #118) (#121)
55b8c56 
* Upgrade TypeScript

See eslint/typescript-eslint-parser#505.

* Remove inline Prettier configs (fixes #118)

Moves missing rule to `.prettierrc`.

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastoland @JamesHenry