Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Prettier configs override prettierrc #118

Closed
texastoland opened this issue Jul 20, 2018 · 2 comments
Closed

Prettier configs override prettierrc #118

texastoland opened this issue Jul 20, 2018 · 2 comments

Comments

@texastoland
Copy link
Contributor

texastoland commented Jul 20, 2018

plugin:shopify/typescript-prettier and plugin:shopify/prettier pass Prettier config inline overriding any external config. It can be worked around but it took me a few hours to figure out why:

  prettier/prettier:
    - error
    - parser: typescript
@BPScott
Copy link
Member

BPScott commented Jul 20, 2018

I'm fairly sure we can remove these overrides as we should trust the project's settings.

@texastoland
Copy link
Contributor Author

texastoland commented Jul 21, 2018

I just fixed typescript-eslint-parser for TypeScript 3. I'll PR this and bump that at the same time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants