Fix: Replace removed API with public flags (fixes #498)

[texastoland]

LGTM on master except maybe the version change to TypeScript.

[jsf-clabot]

All committers have signed the CLA.

[texastoland]

Looks like the build failure just needs restarted?

[j-f1]

@texastoland you can close & reopen the PR to restart the build.

[texastoland]

I'll wait a day or so to make sure there's nothing else to fix first.

[texastoland]

🛎 ping 💢

[sbason]

Would love this to be merged if it works :)

[texastoland]

@sbason you can add my branch to your package.json to try it. It definitely works. All I did is replace 3 deprecated APIs that got removed because of a major version change. Output stayed the same.

[JamesHenry]

TypeScript 3 support needs to be managed in its own branch until it is the stable release. I will create a protected branch for that now and you can use that as the target for the PR. You can then install from that branch on github if you are using the RC.

Please also keep PRs focused on one thing, rather than tweaking multiple unrelated things.

[JamesHenry]

The TypeScript 3 branch is now available: ts-3.0

https://github.com/eslint/typescript-eslint-parser/tree/ts-3.0

Please open a new PR with that as the base

[texastoland]

@JamesHenry these changes are not specific to TypeScript 3. The parser has been using internal and deprecated APIs for a long time. None of the tests had to change. This is strictly a patch version intended for master. I can remove the commit upgrading TypeScript (strictly a dev dependency) however.

[texastoland]

🙏🏽 request to reopen please.

[JamesHenry]

Please remove the TypeScript upgrade, then we can merge it

[j-f1]

If the PR is closed and the head branch is updated, it’s not possible to re-open it until the head branch gets reset to the old commit.

[JamesHenry]

A new PR can always be opened at least! :)