add totals as measurements #284
Conversation
olwijn
requested review from
anders-kiaer,
olelod and
wouterjdb
as code owners
| @@ -187,6 +187,9 @@ def _calculate_wconhist(self): | |||
| oil_rate=value["WOPR"], | |||
| water_rate=value["WWPR"], | |||
| gas_rate=value["WGPR"], | |||
| oil_total=value["WOPT"], | |||
There was a problem hiding this comment.
Recalculating could potentially mean that one doesn't have to supply this at all.
src/flownet/data/from_flow.py
Outdated
| @@ -153,7 +156,7 @@ def _production_data(self) -> pd.DataFrame: | |||
| * Improve robustness pf setting of Phase and Type. | |||
|
|
|||
| """ | |||
| keys = ["WOPR", "WGPR", "WWPR", "WBHP", "WTHP", "WGIR", "WWIR", "WSTAT"] | |||
| keys = ["WOPR", "WGPR", "WWPR", "WOPT", "WGPT", "WWPT", "WBHP", "WTHP", "WGIR", "WWIR", "WGIT", "WWIT", "WSTAT"] | |||
There was a problem hiding this comment.
You're adding WGIT and WWIT here but not in the documentation a few lines earlier and neither are they added in src/flownet/config_parser/_config_parser.py. Is that intentional?
Should you read those values at all? You can reconstruct the cumulative at any given date by calculating the cumulative sum over the rates (this would also be easier to use later on in other data sources)? Or do we expect big differences based on differences in reporting steps?
There was a problem hiding this comment.
Edit: Sorry, you are only referring to injection here @wouterjdb. Then you may be right.
The rates are instantaneous, and depending on the report step length we can get a quite different result reading the actual cumulative volumes and calculating them from rates. Over the years when doing uncertainty studies I have always calculated average yearly or monthly rates from cumulative volumes - for history matching purposes I guess the instantaneous rates are important - what I am saying is that we may need to import both then.
There was a problem hiding this comment.
We will only be using WGIT and WWIT if we prescribe BHP instead of the well rates during the history matching. Although I am not sure if there are cases where you would prefer to do that, I thought it would be good for completeness to just add them. I forgot about adding them to src/flownet/config_parser/_config_parser.py.
| @@ -136,6 +136,51 @@ def _to_abs_path(path: Optional[str]) -> str: | |||
| }, | |||
| }, | |||
| }, | |||
| "WOPT": { | |||
There was a problem hiding this comment.
When adding WOPT (or WGPT or WWPT), should we allow for also adding WOPR (or WGPR or WWPR)? Conditioning on both rates and cumulatives i guess is kind of a messy thing with all the correlation going on. Should we add a check in the config_parser to make sure both are not defined?
Update: Let's leave it for now and add an issue on it so we don't forget about it completely
There was a problem hiding this comment.
I will make a new issue suggesting this and add an item to the CHANGELOG
Insert a description of your pull request (PR) here, and check off the boxes below when they are done.
Contributor checklist
CHANGELOG.md.