Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add totals as measurements #284

Merged
merged 13 commits into from
Jan 4, 2021
Merged

add totals as measurements #284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
35d30f2
add totals as measurements
olwijn Dec 7, 2020
a0099a3
Merge branch 'master' into matchtotals
olwijn Dec 10, 2020
c923fb8
fixed formatting
olwijn Dec 10, 2020
c27bdce
add WWIT and WGIT as observations
olwijn Dec 11, 2020
2473423
extended observation test file with cumulative rates
olwijn Dec 11, 2020
c23d83f
fixed error in ProductionData.csv
olwijn Dec 15, 2020
0bd324f
fixed formatting observation templates
olwijn Dec 15, 2020
9008270
fixed bugs in yamlobs template
olwijn Dec 17, 2020
2cfae7b
Merge branch 'master' into matchtotals
olwijn Dec 17, 2020
68df07a
Merge branch 'master' into matchtotals
olwijn Dec 18, 2020
1a5fa28
Merge branch 'matchtotals' of github.com:olwijn/flownet into matchtotals
olwijn Dec 18, 2020
08e0253
updated CHANGELOG.md
olwijn Dec 18, 2020
6b91364
Merge branch 'master' into matchtotals
olelod Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions src/flownet/config_parser/_config_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,51 @@ def _to_abs_path(path: Optional[str]) -> str:
},
},
},
"WOPT": {
Copy link
Collaborator

@olelod olelod Dec 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding WOPT (or WGPT or WWPT), should we allow for also adding WOPR (or WGPR or WWPR)? Conditioning on both rates and cumulatives i guess is kind of a messy thing with all the correlation going on. Should we add a check in the config_parser to make sure both are not defined?

Update: Let's leave it for now and add an issue on it so we don't forget about it completely

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a new issue suggesting this and add an item to the CHANGELOG

MK.Type: types.NamedDict,
MK.Content: {
"rel_error": {
MK.Type: types.Number,
MK.Required: False,
MK.AllowNone: True,
},
"min_error": {
MK.Type: types.Number,
MK.Required: False,
MK.AllowNone: True,
},
},
},
"WGPT": {
MK.Type: types.NamedDict,
MK.Content: {
"rel_error": {
MK.Type: types.Number,
MK.Required: False,
MK.AllowNone: True,
},
"min_error": {
MK.Type: types.Number,
MK.Required: False,
MK.AllowNone: True,
},
},
},
"WWPT": {
MK.Type: types.NamedDict,
MK.Content: {
"rel_error": {
MK.Type: types.Number,
MK.Required: False,
MK.AllowNone: True,
},
"min_error": {
MK.Type: types.Number,
MK.Required: False,
MK.AllowNone: True,
},
},
},
"WOPR": {
MK.Type: types.NamedDict,
MK.Content: {
Expand Down
5 changes: 4 additions & 1 deletion src/flownet/data/from_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ def _production_data(self) -> pd.DataFrame:
- WOPR Well Oil Production Rate
- WGPR Well Gas Production Rate
- WWPR Well Water Production Rate
- WOPT Well Cumulative Oil Production
- WGPT Well Cumulative Gas Production Rate
- WWPT Well Cumulative Water Production Rate
- WBHP Well Bottom Hole Pressure
- WTHP Well Tubing Head Pressure
- WGIR Well Gas Injection Rate
Expand All @@ -153,7 +156,7 @@ def _production_data(self) -> pd.DataFrame:
* Improve robustness pf setting of Phase and Type.

"""
keys = ["WOPR", "WGPR", "WWPR", "WBHP", "WTHP", "WGIR", "WWIR", "WSTAT"]
keys = ["WOPR", "WGPR", "WWPR", "WOPT", "WGPT", "WWPT", "WBHP", "WTHP", "WGIR", "WWIR", "WGIT", "WWIT", "WSTAT"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're adding WGIT and WWIT here but not in the documentation a few lines earlier and neither are they added in src/flownet/config_parser/_config_parser.py. Is that intentional?

Should you read those values at all? You can reconstruct the cumulative at any given date by calculating the cumulative sum over the rates (this would also be easier to use later on in other data sources)? Or do we expect big differences based on differences in reporting steps?

Copy link
Collaborator

@olelod olelod Dec 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Sorry, you are only referring to injection here @wouterjdb. Then you may be right.

The rates are instantaneous, and depending on the report step length we can get a quite different result reading the actual cumulative volumes and calculating them from rates. Over the years when doing uncertainty studies I have always calculated average yearly or monthly rates from cumulative volumes - for history matching purposes I guess the instantaneous rates are important - what I am saying is that we may need to import both then.

Copy link
Collaborator Author

@olwijn olwijn Dec 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will only be using WGIT and WWIT if we prescribe BHP instead of the well rates during the history matching. Although I am not sure if there are cases where you would prefer to do that, I thought it would be good for completeness to just add them. I forgot about adding them to src/flownet/config_parser/_config_parser.py.


df_production_data = pd.DataFrame()

Expand Down
3 changes: 3 additions & 0 deletions src/flownet/realization/_schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ def _calculate_wconhist(self):
oil_rate=value["WOPR"],
water_rate=value["WWPR"],
gas_rate=value["WGPR"],
oil_total=value["WOPT"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recalculating could potentially mean that one doesn't have to supply this at all.

water_total=value["WWPT"],
gas_total=value["WGPT"],
bhp=value["WBHP"],
thp=value["WTHP"],
)
Expand Down
6 changes: 6 additions & 0 deletions src/flownet/realization/_simulation_keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ def __init__(
oil_rate: float = np.nan,
water_rate: float = np.nan,
gas_rate: float = np.nan,
oil_total: float = np.nan,
water_total: float = np.nan,
gas_total: float = np.nan,
vfp_table: str = "1*",
artificial_lift: str = "1*",
thp: float = np.nan,
Expand All @@ -120,6 +123,9 @@ def __init__(
self.oil_rate: float = oil_rate
self.water_rate: float = water_rate
self.gas_rate: float = gas_rate
self.oil_total: float = oil_total
self.water_total: float = water_total
self.gas_total: float = gas_total
self.vfp_table: str = vfp_table
self.artificial_lift: str = artificial_lift
self.thp: float = thp
Expand Down
10 changes: 10 additions & 0 deletions src/flownet/templates/observations.ertobs.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
{%- set index_name = date.strftime('%d_%m_%Y') -%}
{%- set date_formatted = date.strftime('%d/%m/%Y') %}

{%- if not isnan(kw.oil_total) and error_config.WOPT.rel_error is not none and error_config.WOPT.min_error is not none: -%}
SUMMARY_OBSERVATION WOPT_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.oil_total }}; ERROR = {{ [error_config.WOPT.rel_error * kw.oil_total, error_config.WOPT.min_error] | max }}; DATE = {{ date_formatted }}; KEY = WOPT:{{ kw.well_name }}; };
{%- endif %}
{%- if not isnan(kw.gas_total) and error_config.WGPT.rel_error is not none and error_config.WGPT.min_error is not none: %}
SUMMARY_OBSERVATION WGPT_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.gas_total }}; ERROR = {{ [error_config.WGPT.rel_error * kw.gas_total, error_config.WGPT.min_error] | max }}; DATE = {{ date_formatted }}; KEY = WGPT:{{ kw.well_name }}; };
{%- endif %}
{%- if not isnan(kw.water_total) and error_config.WWPT.rel_error is not none and error_config.WWPT.min_error is not none: %}
SUMMARY_OBSERVATION WWPT_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.water_total }}; ERROR = {{ [error_config.WWPT.rel_error * kw.water_total, error_config.WWPT.min_error] | max }}; DATE = {{ date_formatted }}; KEY = WWPT:{{ kw.well_name }}; };
{%- endif %}

{%- if not isnan(kw.oil_rate) and error_config.WOPR.rel_error is not none and error_config.WOPR.min_error is not none: -%}
SUMMARY_OBSERVATION WOPR_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.oil_rate }}; ERROR = {{ [error_config.WOPR.rel_error * kw.oil_rate, error_config.WOPR.min_error] | max }}; DATE = {{ date_formatted }}; KEY = WOPR:{{ kw.well_name }}; };
{%- endif %}
Expand Down
37 changes: 37 additions & 0 deletions src/flownet/templates/observations.yamlobs.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,41 @@
smry:
{%- for well_name in schedule.get_wells(kw_class="WCONHIST") -%}
{%- if (error_config.WOPT.rel_error is not none) and (error_config.WOPT.min_error is not none) -%}
{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="oil_total") -%}
{% if loop.first and not loop.last: %}
- key: WOPT:{{ well_name }}
observations:
{%- elif not loop.first: %}
- date: {{ kw.date.strftime('%Y-%m-%d') }}
value: {{ kw.oil_total }}
error: {{ [error_config.WOPT.rel_error * kw.oil_total, error_config.WOPT.min_error] | max }}
{%- endif -%}
{%- endfor %}
{%- endif -%}
{%- if (error_config.WWPT.rel_error is not none) and (error_config.WWPT.min_error is not none) -%}
{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="water_total") -%}
{% if loop.first and not loop.last: %}
- key: WWPT:{{ well_name }}
observations:
{%- elif not loop.first: %}
- date: {{ kw.date.strftime('%Y-%m-%d') }}
value: {{ kw.water_total }}
error: {{ [error_config.WWPT.rel_error * kw.water_total, error_config.WWPT.min_error] | max }}
{%- endif -%}
{%- endfor %}
{%- endif -%}
{%- if (error_config.WGPT.rel_error is not none) and (error_config.WGPT.min_error is not none) -%}
{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="gas_total") -%}
{% if loop.first and not loop.last: %}
- key: WGPT:{{ well_name }}
observations:
{%- elif not loop.first: %}
- date: {{ kw.date.strftime('%Y-%m-%d') }}
value: {{ kw.gas_total }}
error: {{ [error_config.WGPT.rel_error * kw.gas_total, error_config.WGPT.min_error] | max }}
{%- endif -%}
{%- endfor %}
{%- endif -%}
{%- if (error_config.WOPR.rel_error is not none) and (error_config.WOPR.min_error is not none) -%}
{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="oil_rate") -%}
{% if loop.first and not loop.last: %}
Expand All @@ -12,6 +48,7 @@ smry:
{%- endif -%}
{%- endfor %}
{%- endif -%}

{%- if (error_config.WGPR.rel_error is not none) and (error_config.WGPR.min_error is not none) -%}
{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="gas_rate") -%}
{% if loop.first and not loop.last: %}
Expand Down