Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure disappears after pressing 'Layout' and the app crashes #3208

Closed
Zhirnoff opened this issue Aug 29, 2023 · 1 comment · Fixed by #3264 or #3282
Closed

Structure disappears after pressing 'Layout' and the app crashes #3208

Zhirnoff opened this issue Aug 29, 2023 · 1 comment · Fixed by #3264 or #3282
Assignees
@chgayane
Labels
Priority: High
Milestone
Ketcher 2.15.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Open attached file sbs_48.zip and put to canvas
  3. Press 'Layout' button

Actual behavior
Structure disappears after pressing Layout and an atom appears in the left corner of canvas. It is not possible to clear the canvas or move the atom that appears. There are multiple errors in the DevTools console. The application becomes inoperable.

Expected behavior
After applying 'Lyout', the structure does not disappear and can be interacted with.

Screenshots
2023-08-29_13h42_48

2023-08-29_13h49_21.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.14.0-rc.2

#185911657
@Zhirnoff Zhirnoff added this to the Refined Backlog milestone Aug 29, 2023
@Nitvex Nitvex assigned chgayane and unassigned Nitvex Aug 30, 2023
chgayane pushed a commit that referenced this issue Sep 4, 2023
#3208 - Fixed structure disappearance and app crash when pressing on …
e9db9ee 
…'Layout
@chgayane chgayane linked a pull request Sep 4, 2023 that will close this issue
#3208 - Structure disappears after pressing 'Layout' and the app crashes #3245
Closed
9 tasks
chgayane pushed a commit that referenced this issue Sep 4, 2023
#3208 - 'label' redeclaration to 'const'
5cae8cc
chgayane pushed a commit that referenced this issue Sep 4, 2023
#3208 - autotest for the structure does not disappear after pressing …
27e01c9 
…Layout
chgayane pushed a commit that referenced this issue Sep 5, 2023
#3208 - molfile name changing
ff5ea96
chgayane pushed a commit that referenced this issue Sep 5, 2023
#3208 - Fixed structure disappearance and app crash when pressing on …
fdcc1a8 
…'Layout
chgayane pushed a commit that referenced this issue Sep 5, 2023
#3208 - 'label' redeclaration to 'const'
ce1c5c1
chgayane pushed a commit that referenced this issue Sep 5, 2023
#3208 - autotest for the structure does not disappear after pressing …
90f66aa 
…Layout
chgayane pushed a commit that referenced this issue Sep 5, 2023
#3208 - molfile name changing
170c3a2
chgayane pushed a commit that referenced this issue Sep 6, 2023
#3208 - structure disappearance by pressing layout
bc7bb8a
chgayane pushed a commit that referenced this issue Sep 6, 2023
#3208 - Fixed structure disappearance and app crash when pressing on …
57f9631 
…'Layout
@chgayane chgayane linked a pull request Sep 6, 2023 that will close this issue
Backmerge: #3208 - Structure disappears after pressing 'Layout' and the app crashes #3260
Closed
9 tasks
chgayane pushed a commit that referenced this issue Sep 6, 2023
#3208 - 'label' redeclaration to 'const'
1fa7079
@Nitvex Nitvex added this to the Ketcher 2.15.0-rc.2 milestone Sep 6, 2023
chgayane pushed a commit that referenced this issue Sep 6, 2023
#3208 - 'label' redeclaration to 'const'
6b142ea
chgayane pushed a commit that referenced this issue Sep 6, 2023
#3208 - structure disappearance by pressing layout
b45c734
chgayane pushed a commit that referenced this issue Sep 6, 2023
#3208 - structure disappearance by pressing layout
2afee46
chgayane pushed a commit that referenced this issue Sep 6, 2023
#3208 - Remove unused 'openFile' variable declaration
d534bf4
@Nitvex Nitvex linked a pull request Sep 6, 2023 that will close this issue
#3208 - Structure disappears after pressing 'Layout' and the app crashes #3264
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Sep 6, 2023

Pre-tested. Bug is fixed.

2023-09-06_18h07_23

chgayane pushed a commit that referenced this issue Sep 7, 2023
#3208 - simplify 'Stereo flag' test by using a loop and refactor 'Cen…
519e677 
…ter molecule after layout' test
chgayane pushed a commit that referenced this issue Sep 7, 2023
#3208 - Refactor code to ensure 'label' object is properly initialized
94e8124
chgayane pushed a commit that referenced this issue Sep 8, 2023
#3208 - Refactor code to ensure 'label' object is properly initialized
8f09f12
Nitvex added a commit that referenced this issue Sep 8, 2023
@Nitvex
#3208 – fix tests
1c6f393
Nitvex added a commit that referenced this issue Sep 8, 2023
@Nitvex
#3208 – fix tests
eb9b7a0
Nitvex added a commit that referenced this issue Sep 8, 2023
@Nitvex
#3208 – fix tests
6f12cdc
Nitvex added a commit that referenced this issue Sep 8, 2023
@Nitvex
#3208 – fix tests
1432946
Nitvex added a commit that referenced this issue Sep 8, 2023
@chgayane @Nitvex
#3208 - Structure disappears after pressing 'Layout' and the app cras…
c147c6a 
…hes (#3264)

* #3208 - structure disappearance by pressing layout

* #3208 - Remove unused 'openFile' variable declaration

* #3208 - simplify 'Stereo flag' test by using a loop and refactor 'Center molecule after layout' test

* #3208 - Refactor code to ensure 'label' object is properly initialized

* #3208 – fix tests

---------

Co-authored-by: Gayane Chilingaryan <[email protected]>
Co-authored-by: Nikita_Vozisov <[email protected]>
Nitvex added a commit that referenced this issue Sep 8, 2023
@chgayane @Nitvex
Backmerge: #3208 - structure disappearance by pressing layout
cfc2e8e 
* #3208 - Remove unused 'openFile' variable declaration

* #3208 - simplify 'Stereo flag' test by using a loop and refactor 'Center molecule after layout' test

* #3208 - Refactor code to ensure 'label' object is properly initialized

* #3208 – fix tests

---------

Co-authored-by: Gayane Chilingaryan <[email protected]>
Co-authored-by: Nikita_Vozisov <[email protected]>
@Nitvex Nitvex mentioned this issue Sep 8, 2023
Merged
9 tasks
@Nitvex Nitvex linked a pull request Sep 8, 2023 that will close this issue
Backmerge: #3208 - Structure disappears after pressing 'Layout' and the app crashes #3282
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Sep 15, 2023
@Nitvex @chgayane
Backmerge: #3208 - structure disappearance by pressing layout (#3282)
f2ba2a1 
* #3208 - Remove unused 'openFile' variable declaration

* #3208 - simplify 'Stereo flag' test by using a loop and refactor 'Center molecule after layout' test

* #3208 - Refactor code to ensure 'label' object is properly initialized

---------

Co-authored-by: gayane_chilingaryan <[email protected]>
Co-authored-by: Gayane Chilingaryan <[email protected]>
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.15.0-rc.2
3 participants
@Nitvex @Zhirnoff @chgayane