#3208 - Structure disappears after pressing 'Layout' and the app crashes #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the "Edit" or "Query properties" tab in the context menu disappears when clicking on the canvas (#3237) * #3224 - Appearing label near the Template after choosing any option in the "Edit" or "Query properties" tab in the context menu disappears when clicking on the canvas * Forbid ".only" tests in CI environment
auto-assign
bot
requested review from
AKZhuk,
AnastasiyaPiatrovaKlu and
KonstantinEpam23
* 3169 - Autotests for Open and Save InChi format * #3169 - updated snapshots * 3169 - adding waitForIndigoToLoad, kebab case for data-testids * #3169 - removed only * #3169 - resolved case-sensitivity conflict * #3169 - fixed ci_enviroment false statement --------- Co-authored-by: Gayane Chilingaryan <[email protected]>
KonstantinEpam23
approved these changes
Sep 5, 2023
| // Related Github issue: https://github.com/epam/ketcher/issues/3208 | ||
| await openFileAndAddToCanvas('Molfiles-V2000/sbs_48.mol', page); | ||
| await selectTopPanelButton(TopPanelButton.Layout, page); | ||
| await takeEditorScreenshot(page); |
There was a problem hiding this comment.
Hmm, might need to wait for Indigo here?
There was a problem hiding this comment.
Is it necessary to wait for some time after pressing the layout button to check if the structure has disappeared, if the button immediately arranges structures in place?
AKZhuk
approved these changes
Sep 5, 2023
* - added tests for 'charge tool'; - added 1 test file; - added expected snapshots * - moved test files to folders * - added ignored hotkeys to 'hotkeys.ts'; - deleted 'delay' * - deleted 'delay' from import * - changed name of folder 'Ket' to 'KET' * - updated snapshot * - updated expected snapshots; - added folder path to some tests; - delete 'fixme' from some tests * - updated snapshots; - code refactoring; - added 'INPUT_DELAY' to functions 'cutAndPaste' and 'copyAndPaste' * - deleted duplicate folder with tests * -updated snapshots; - fixed some tests * - updated snapshots; - fixed some tests * - fix 1 test * - fixed some tests; - removed 'fixme' and 'skip' * - updated snapshot
…-app-crashes' of https://github.com/epam/ketcher into 3208-structure-disappears-after-pressing-layout-and-the-app-crashes
chgayane
deleted the
3208-structure-disappears-after-pressing-layout-and-the-app-crashes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works?
Structure disappears after pressing Layout and an atom appears in the left corner of canvas.
How did you fix the issue?
Checking if the label is an object before attempting to set its 'path' property.
Ketcher.v2.14.0.Vite.-.Google.Chrome.2023-09-04.14-13-07.mp4
Check list
#1234 – issue name