Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #3208 - Structure disappears after pressing 'Layout' and the app crashes #3260

Conversation

chgayane
Copy link
Collaborator

@chgayane chgayane commented Sep 6, 2023

How the feature works?
Structure disappears after pressing Layout and an atom appears in the left corner of canvas.

How did you fix the issue?
Checking if the label is an object before attempting to set its 'path' property.

Ketcher.v2.14.0.Vite.-.Google.Chrome.2023-09-04.14-13-07.mp4

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@chgayane chgayane self-assigned this Sep 6, 2023
@chgayane chgayane linked an issue Sep 6, 2023 that may be closed by this pull request
@chgayane chgayane marked this pull request as ready for review September 6, 2023 09:52
@auto-assign auto-assign bot requested review from Nitvex and vitaepam September 6, 2023 09:52
@Nitvex Nitvex changed the title #3208 - Structure disappears after pressing 'Layout' and the app crashes Backmerge: #3208 - Structure disappears after pressing 'Layout' and the app crashes Sep 6, 2023
@Nitvex
Copy link
Collaborator

Nitvex commented Sep 8, 2023

closing this as Backmerge is here: #3282

@Nitvex Nitvex closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure disappears after pressing 'Layout' and the app crashes
4 participants