Fix leaks after calling wasm drop #7038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dering-after-drop-6505 Merge remote-tracking branch 'origin/develop' into wip/procrat/no-rendering-after-drop-6505
…dering-after-drop-6505
…dering-after-drop-6505
farmaazon
added
the
CI: No changelog needed
farmaazon
requested review from
MichaelMauderer,
wdanilo,
kazcw and
mwu-tow
as code owners
kazcw
approved these changes
Jun 16, 2023
| options | ||
| // | ||
| // 2. We want to prevent default action on wheel events, thus listener cannot be passive. | ||
| web::EventListenerHandleOptions::new().passive() |
There was a problem hiding this comment.
Should this be not_passive()?
lib/rust/frp/src/io/js.rs
Outdated
| // We want to prevent default action on wheel events, thus listener cannot be passive. | ||
| options.passive(false); | ||
| options | ||
| enso_web::EventListenerHandleOptions::new().passive() |
wdanilo
approved these changes
Jun 18, 2023
lib/rust/web/src/lib.rs
Outdated
Comment on lines
757
to
766
| pub fn passive(mut self) -> Self { | ||
| self.passive = Some(true); | ||
| self | ||
| } | ||
|
|
||
| pub fn not_passive(mut self) -> Self { | ||
| self.passive = Some(false); | ||
| self | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add here docs. It's not obvious what these do after reading the name if someone (like me) do not remember what the JS side does.
lib/rust/web/src/lib.rs
Outdated
Comment on lines
855
to
856
|
|
||
|
|
…dering-after-drop-6505
QA: 🟢 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
Remove a leak detector added in #7038, that has a large (~10s) impact on startup performance. I missed the performance impact during QA, but noticed it after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This should finally fix #6505
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.