Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup performance bug #7089

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Fix startup performance bug #7089

merged 4 commits into from
Jun 22, 2023

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Jun 20, 2023

Pull Request Description

Remove a leak detector added in #7038, that has a large (~10s) impact on startup performance. I missed the performance impact during QA, but noticed it after merge.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw requested a review from MichaelMauderer as a code owner June 20, 2023 19:57
@kazcw kazcw self-assigned this Jun 20, 2023
@kazcw kazcw requested review from wdanilo and farmaazon as code owners June 20, 2023 19:57
@kazcw kazcw added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Jun 20, 2023
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no leak detector in production code (they're just debugging tools), removed it from one place more.

@mergify mergify bot merged commit 9ae4b24 into develop Jun 22, 2023
@mergify mergify bot deleted the wip/kw/fix-startup-time branch June 22, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants